Closed
Bug 887184
Opened 11 years ago
Closed 11 years ago
Commit message hook should exempt gaia.json auto-commits
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file, 1 obsolete file)
1.80 KB,
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
I've just hit the commit message hook trying to merge birch to mozilla-central, due to gaia.json auto commits that do not contain a bug number. We should: 1) Make the commit message hook exempt "Bumping gaia.json". 2) Switch on the commit message hook for birch, so we catch things before merging to m-c. This bug covers #1.
Assignee | ||
Comment 1•11 years ago
|
||
Filed bug 887193 for #2.
Assignee | ||
Comment 2•11 years ago
|
||
Exempts gaia.json auto commits [1] & removes the now redundant nanojit-import exemption (nanojit is no longer in the tree as of bug 698201). [1] Example: https://hg.mozilla.org/mozilla-central/rev/b77e4465858c
Attachment #767683 -
Flags: review?(evilpies)
Comment 3•11 years ago
|
||
Comment on attachment 767683 [details] [diff] [review] Patch v1 Review of attachment 767683 [details] [diff] [review]: ----------------------------------------------------------------- Have you considered checking the user instead of the commit message? We already check for some users, but I am not even sure what they all are.
Attachment #767683 -
Flags: review?(evilpies) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Yeah let's do that instead. Also removes two unnecessary imports that pyflakes was complaining about.
Attachment #767745 -
Flags: review?(evilpies)
Assignee | ||
Updated•11 years ago
|
Attachment #767683 -
Attachment is obsolete: true
Comment 5•11 years ago
|
||
Comment on attachment 767745 [details] [diff] [review] Patch v2 Review of attachment 767745 [details] [diff] [review]: ----------------------------------------------------------------- I would feel better if this had a test, but Ed told me that the don't even run for him. :(
Attachment #767745 -
Flags: review?(evilpies) → review+
Comment 6•11 years ago
|
||
Wouldn't it be simpler to change the gaia.json-bumping script to include "no bug" in the commit message, rather than adding another special case to the hook?
Comment 7•11 years ago
|
||
That is more of hack and not the intended purpose of "no bug".
Comment 8•11 years ago
|
||
What is "no bug" for, if not for changes which aren't tracked by bugs? I'm not sure the semantic distinction you're making is useful :)
Assignee | ||
Comment 9•11 years ago
|
||
I'm just going to go with the approach in the attached patch: https://hg.mozilla.org/hgcustom/hghooks/rev/0c5570033c6b
Comment 10•11 years ago
|
||
Looks good.
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Updated•10 years ago
|
Product: Release Engineering → Developer Services
You need to log in
before you can comment on or make changes to this bug.
Description
•