Closed
Bug 887202
Opened 12 years ago
Closed 12 years ago
Add errors module to have a central location for custom errors
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [mozmill-2.0][ateamtrack: p=mozmill q=2013q2 m=4])
Attachments
(1 file)
|
16.05 KB,
patch
|
davehunt
:
review+
|
Details | Diff | Splinter Review |
Right now all of our custom errors are spread around in separate files. We should really have a central location, which we can import and even my accessible by default for tests, e.g. errors.TimeoutError.
I need this because I will add one more custom type in bug 865690.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #767716 -
Flags: review?(dave.hunt)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 767716 [details] [diff] [review]
Patch v1
Review of attachment 767716 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, and a really nice improvement.
Attachment #767716 -
Flags: review?(dave.hunt) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Landed on master:
https://github.com/mozilla/mozmill/commit/9d39aaef0484e74a435af3702102f25b7eaa2f43
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [mozmill-2.0] → [mozmill-2.0][ateamtrack: p=mozmill q=2013q2 m=4]
|
||
Updated•9 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•