887234 - Make leakstats not fail the build job on OS X if the log file was incomplete, until bug 774844 is fixed

Status: RESOLVED WONTFIX

(Testing :: General, defect)

Description

[Ed Morley [:emorley]]

Bug 774844 is causing additional infra load due to people unnecessarily retriggering OS X build jobs on Try - which then spawns another 3 platforms worth of tests.

Both to save the infra load and the sheriffs sanity (this is a fairly frequent intermittent failure), we should make the "log file incomplete" failure mode [1] a warning on OS X, rather than allowing it to fail the entire build job.

[1] http://mxr.mozilla.org/mozilla-central/source/tools/trace-malloc/leakstats.c#140

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

For now turns the failure into a warning on OS X. We can't exit(0) immediately, since otherwise the lack of a summary will cause us to hit https://hg.mozilla.org/build/buildbotcustom/file/4731c6859855/steps/test.py#l231 which in turn means we'll fail at https://hg.mozilla.org/build/buildbotcustom/file/4731c6859855/steps/test.py#l190

We'll still need to decide whether we even find the leak stats useful and if not remove the buildsteps entirely.

Comment 2

[Phil Ringnalda (:philor)]

Fun fact: the buildbot function that looks for the tipmost revision which is safe to build a nightly on considers debug builds, so hitting this constant failure means that we fail to ship things in m-c nightlies for absolutely no reason.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 767719 [details] [diff] [review]
Patch v1

Can we fix this at a higher layer?  Printing out totally bogus leak stats seems likely to be harmful in the long run.

Comment 4

[Ed Morley [:emorley]]

WONTFIXing in favour of bug 617441.