Closed
Bug 887244
Opened 11 years ago
Closed 11 years ago
Style list view dividers in new about:home as per design
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect, P1)
Firefox for Android Graveyard
Awesomescreen
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: lucasr, Unassigned)
References
Details
(Whiteboard: fixed-fig)
Attachments
(2 files, 1 obsolete file)
|
1.23 KB,
patch
|
sriram
:
review+
|
Details | Diff | Splinter Review |
|
5.82 KB,
patch
|
sriram
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•11 years ago
|
||
Attachment #767751 -
Flags: review?(sriram)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Attachment #767752 -
Flags: review?(sriram)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 767751 [details] [diff] [review]
(1/2) Fix typo in BaseListView style name
Review of attachment 767751 [details] [diff] [review]:
-----------------------------------------------------------------
Oops.
Attachment #767751 -
Flags: review?(sriram) → review+
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 767752 [details] [diff] [review]
(2/2) Style list view dividers in new about:home as per design
Review of attachment 767752 [details] [diff] [review]:
-----------------------------------------------------------------
I somehow don't like this approach. The idea behind HomeListView using @android:attr/listViewStyle is that all those list views look one and the same, and we can set a theme level attribute. Adding a style attribute for each XML block somehow doesn't fit with that approach.
Here's how I would do it:
1. Add a theme level attribute "homeListViewStyle" to attrs.xml.
2. Use this attribute as default style in HomeListView.
3. Add a Widget.HomeListView style in styles.xml that inherits from Widget.ListView and make changes needed.
Attachment #767752 -
Flags: review?(sriram) → review-
|
||
Updated•11 years ago
|
Priority: -- → P1
|
|
Reporter | |
Comment 5•11 years ago
|
||
Attachment #772705 -
Flags: review?(sriram)
|
|
Reporter | |
Updated•11 years ago
|
Attachment #767752 -
Attachment is obsolete: true
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 772705 [details] [diff] [review]
Style list view dividers in new about:home as per design
Review of attachment 772705 [details] [diff] [review]:
-----------------------------------------------------------------
You would have to add it in values-v11/themes.xml too. r+ with that.
Attachment #772705 -
Flags: review?(sriram) → review+
|
|
Reporter | |
Comment 7•11 years ago
|
||
Pushed:
http://hg.mozilla.org/projects/fig/rev/603440bf0f33
http://hg.mozilla.org/projects/fig/rev/b060b1c135c6
Whiteboard: fixed-fig
|
||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/603440bf0f33
https://hg.mozilla.org/mozilla-central/rev/b060b1c135c6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•