887273 - web console: mixed content warnings show even when all logging is disabled

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Jeff]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130512194445

Steps to reproduce:

Tested on Nighly 24.0a1 (2013-06-23):
Open new tab
Open web console
Disable all loggers (Net, CSS, JS, Security, Logging
Go to https://ie.microsoft.com/testdrive/browser/mixedcontent/assets/woodgrove.htm



Actual results:

Mixed content errors are being displayed


Expected results:

Mixed content errors should not be displayed with "Net" and "Security" loggers being disabled

Comment 1

[Alice0775 White]

Confirmed

Comment 2

[Mihai Sucan [:msucan]]

Thanks for the bug report! I cannot confirm this issue with nightlies. Is this bug specific to firefox 24 (aurora) only?

Comment 3

[Alice0775 White]

I can reproduce in Nightly24.0a1 too
http://hg.mozilla.org/mozilla-central/rev/3b955f306226
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130627 Firefox/25.0 ID:20130627031027

Comment 4

[Alice0775 White]

oops
I can reproduce in Nightly25.0a1 too

Comment 5

[Alice0775 White]

(In reply to Mihai Sucan [:msucan] from comment #2)
> Thanks for the bug report! I cannot confirm this issue with nightlies. Is
> this bug specific to firefox 24 (aurora) only?

You may reload(f5) or clear cache.

And also reproduce on ubuntu.
http://hg.mozilla.org/mozilla-central/rev/3b955f306226
Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20130627 Firefox/25.0 ID:20130627031027

Comment 6

[Mihai Sucan [:msucan]]

It seems that the blocking of mixed content is what made me miss those network messages. I was now able to reproduce the bug. Will submit a patch.

Comment 7

[Jeff]

If you mind: The bug also occurs on 21.0 and 22.0 "old" Firefox versions.

Comment 8

[Mihai Sucan [:msucan]]

(In reply to Jeff from comment #7)
> If you mind: The bug also occurs on 21.0 and 22.0 "old" Firefox versions.

This doesn't seem to be a common issue that would prevent users from doing work. Given it is low impact, we may not need to fix this bug for other versions. We haven't had reports until now.

Comment 9

[Mihai Sucan [:msucan]]

Attachment: proposed patch

This patch adds the Net > Warnings menu item. Now users will be allowed to turn network warnings off/on - including mixed content warnings. Tests included.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=912d08602642

The reporter points out that this is an old bug. Do we want to patch older versions of Firefox? See comment 8 for my thoughts.

Thank you!

Comment 10

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 768971 [details] [diff] [review]
proposed patch

Review of attachment 768971 [details] [diff] [review]:
-----------------------------------------------------------------

lookin' good!

::: browser/devtools/webconsole/test/browser_webconsole_bug_737873_mixedcontent.js
@@ +34,5 @@
> +      category: CATEGORY_NETWORK,
> +      severity: SEVERITY_WARNING,
> +    }],
> +  }).then((results) => {
> +    dump("lolz\n");

only one lolz. need more lolz.

missed dumping?

Comment 11

[Mihai Sucan [:msucan]]

Good catch. I forgot to remove that dump. :) Thanks!

Landed without the dump call:
https://hg.mozilla.org/integration/fx-team/rev/aed4d6e58abe

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aed4d6e58abe

Comment 13

[Jeff]

Wonderful :)