88745 - PathExpr::matches is broken if the path contains //

Status: VERIFIED FIXED

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

PathExpr is broken if any of the contained steps uses an ANCESTOR_OP (//).

Consider for example the following pattern:

"foo/bar//baz"

We first need to check if the 'baz' part matches, then we need to walk up the 
tree until we find a node that matches 'bar'. If the next node up the tree is 
not an 'foo' we need to continue looking for another 'bar' to see if that has 
a 'foo' parent.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I think I can come up with a patch for this but I need bug 85189 checked in 
first.

Comment 2

[Axel Hecht]

This one is solved.

Axel

No, I'm not bored.

Comment 3

[Axel Hecht]

Attachment: attaching style sheet for verification

Comment 4

[Axel Hecht]

Attachment: xml file for verification, uses above stylesheet

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

nope, it dosn't work if there is a element that matches "bar" but it's parent 
dosn't match "foo"...

(untested) testcase coming up

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: xml that dosn't work, uses above stylesheet

Comment 7

[Axel Hecht]

fight!

If I understand your xml correctly, your example is supposed to dump
<out>
   right
</out>
as well, huh?
It does, buddy.
(my testcase had two bar elements, so it wouldn't match for/bar/baz either)

Axel

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

shit!

ok. but it's not optimized

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

this actually worked all along, and the code is rewritten now anyways

Comment 10

[Roland Mainz]

Comment on attachment 43501 [details]
attaching style sheet for verification

Fixing mime type ...

Comment 11

[Peter Van der Beken [:peterv]]

Comment on attachment 43501 [details]
attaching style sheet for verification

Bah. text/xsl does not exist as a mime type, if you try to fix things, at least
make sure you're right.