887493 - Warning: array function find does not always return a value

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

[14:30:12.138] function find does not always return a value @ resource://gre/modules/XPIProvider.jsm -> jar:file:///var/folders/lc/2v6jzk5525gd4l6zr5hxt2yc0000gn/T/tmp4wFM4q.mozrunner/extensions/[e-mail]!/bootstrap.js -> resource://extensions.modules.8bcdffe6-1172-42c6-9d17-1d9dbee21d29-at-jetpack.commonjs.path/toolkit/loader.js -> resource://extensions.modules.8bcdffe6-1172-42c6-9d17-1d9dbee21d29-at-jetpack.commonjs.path/sdk/util/array.js:104

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

I think I'd also change API to `find(array, predicate, fallback)` where `fallback` is what's returned if element isn't found.

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1063/files

Pointer to Github pull-request

Comment 3

[:Irving Reid (No longer working on Firefox)]

This is causing xpcshell test failures in toolkit/devtools/server, because those tests are calling do_throw() when they see unexpected console messages.

The effect of this has been masked by bug 890555, which was causing those do_throw() calls to fail (and thus the test case *not* to fail). Fixing bug 890555 will cause oranges in toolkit/devtools/server unless this warning is fixed or the devtools tests are modified.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1555f801593e8b6d05ec12d9440b0537e5e4ab76
Merge pull request #1063 from Gozala/bug/array-find@887493

Bug 887493 - Improve array find r=@erikvold

Comment 5

[:Irving Reid (No longer working on Firefox)]

This was fixed by the uplift in bug 897683. Also, sorry for accidentally stealing the assignment...