887518 - Addon Manager should be loaded only when required

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Stefan Mirea [:smirea]]

Currently the addon manager in the /services/healthreport/tests/xpcshell file is loaded in head.js which gets included in all tests. This causes "test_provider_addons.js" to fail when compiled on Boot2Gecko and all future tests on that platform that will call the loadAddonManager() function - which is only needed in test_provider_addons.js and therefore should only be defined there

Comment 1

[Reed Loden [:reed]]

This looks test-specific, so why 'checkin-needed' and 'sec-review' here?

Comment 2

[Richard Newman [:rnewman]]

Betcha this was cloned.

Comment 3

[Stefan Mirea [:smirea]]

Attachment: move loadAddonManager() to test_provider_addons.js; ?r=:gps

Moved loadAddonManager() to test_provider_addons.js which is the only file that requires it so it won't break future tests on Boot 2 Gecko

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/49986ca301b5

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/49986ca301b5