Closed
Bug 887518
Opened 12 years ago
Closed 12 years ago
Addon Manager should be loaded only when required
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect)
Firefox Health Report Graveyard
Client: Desktop
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: smirea, Assigned: smirea)
References
Details
Attachments
(1 file)
2.62 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Currently the addon manager in the /services/healthreport/tests/xpcshell file is loaded in head.js which gets included in all tests. This causes "test_provider_addons.js" to fail when compiled on Boot2Gecko and all future tests on that platform that will call the loadAddonManager() function - which is only needed in test_provider_addons.js and therefore should only be defined there
Flags: sec-review?
Comment 1•12 years ago
|
||
This looks test-specific, so why 'checkin-needed' and 'sec-review' here?
Assignee | ||
Comment 3•12 years ago
|
||
Moved loadAddonManager() to test_provider_addons.js which is the only file that requires it so it won't break future tests on Boot 2 Gecko
Attachment #768050 -
Flags: review?(gps)
Updated•12 years ago
|
Attachment #768050 -
Flags: review?(gps) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 4•12 years ago
|
||
Keywords: checkin-needed
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Updated•7 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•