Closed Bug 887518 Opened 6 years ago Closed 6 years ago

Addon Manager should be loaded only when required

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Product:
Firefox Health Report Graveyard
Component:
Client: Desktop
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 26

People

(Reporter: smirea, Assigned: smirea)

References

Details

Attachments

(1 file)

move loadAddonManager() to test_provider_addons.js; ?r=:gps
2.62 KB, patch
gps
: review+
Details | Diff | Splinter Review 
Currently the addon manager in the /services/healthreport/tests/xpcshell file is loaded in head.js which gets included in all tests. This causes "test_provider_addons.js" to fail when compiled on Boot2Gecko and all future tests on that platform that will call the loadAddonManager() function - which is only needed in test_provider_addons.js and therefore should only be defined there
Flags: sec-review?
This looks test-specific, so why 'checkin-needed' and 'sec-review' here?
Betcha this was cloned.
Flags: sec-review?
Keywords: checkin-needed
Moved loadAddonManager() to test_provider_addons.js which is the only file that requires it so it won't break future tests on Boot 2 Gecko
Attachment #768050 - Flags: review?(gps)
Attachment #768050 - Flags: review?(gps) → review+
Blocks: 888030
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/49986ca301b5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.