887524 - Move IDBRequest to WebIDL

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: request.patch

Comment 2

[Jan Varga [:janv]]

Comment on attachment 783691 [details] [diff] [review]
request.patch

Review of attachment 783691 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/IDBRequest.cpp
@@ +24,5 @@
>  #include "IDBEvents.h"
>  #include "IDBFactory.h"
>  #include "IDBTransaction.h"
>  
> +#include "mozilla/dom/IDBOpenDBRequestBinding.h"

Nit: this should go before |#include "nsComponentManagerUtils.h"|

::: dom/indexedDB/IDBRequest.h
@@ +6,5 @@
>  
>  #ifndef mozilla_dom_indexeddb_idbrequest_h__
>  #define mozilla_dom_indexeddb_idbrequest_h__
>  
> +

Nit: remove this empty line

@@ +19,1 @@
>  #include "mozilla/dom/DOMError.h"

#include "mozilla/dom/indexedDB/IndexedDatabase.h"

#include "mozilla/Attributes.h"
#include "mozilla/dom/DOMError.h"
#include "mozilla/dom/IDBRequestBinding.h"
#include "mozilla/ErrorResult.h"
#include "nsCycleCollectionParticipant.h"
#include "nsWrapperCache.h"

#include "mozilla/dom/indexedDB/IDBWrapperCache.h"

@@ +116,5 @@
> +  GetResult(JSContext* aCx, ErrorResult& aRv) const;
> +
> +  nsISupports*
> +  GetSource() const
> +  {

add the main thread assertion, here and below

::: dom/indexedDB/ipc/IndexedDBParent.cpp
@@ +383,5 @@
>  
>    AutoSafeJSContext cx;
>  
> +  ErrorResult error;
> +  JS::Value result = mOpenRequest->GetResult(cx, error);

Is this safe ?

I would expect something like:
JS::Rooted<JS::Value> result ...

Comment 3

[Andrea Marchesini [:baku]]

Attachment: request.patch

Comment 4

[Jan Varga [:janv]]

Comment on attachment 783798 [details] [diff] [review]
request.patch

r=me

Comment 6

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/023d2f835ca0

Comment 7

[Andrea Marchesini [:baku]]

IDBRequest.LOADING and IDBRequest.DONE are gone. Documentation must be updated.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/023d2f835ca0

Comment 9

[Kohei Yoshino [:kohei]]

https://developer.mozilla.org/en-US/docs/Web/API/IDBRequest#Constants
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility