Move IDBRequest to WebIDL

RESOLVED FIXED in mozilla25

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: Ehsan, Assigned: baku)

Tracking

(Blocks: 2 bugs, {addon-compat, dev-doc-complete, site-compat})

Trunk
mozilla25
addon-compat, dev-doc-complete, site-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)

Updated

4 years ago
Blocks: 888591
Assignee: ehsan → amarchesini
Created attachment 783691 [details] [diff] [review]
request.patch
Attachment #783691 - Flags: review?(Jan.Varga)

Comment 2

4 years ago
Comment on attachment 783691 [details] [diff] [review]
request.patch

Review of attachment 783691 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/IDBRequest.cpp
@@ +24,5 @@
>  #include "IDBEvents.h"
>  #include "IDBFactory.h"
>  #include "IDBTransaction.h"
>  
> +#include "mozilla/dom/IDBOpenDBRequestBinding.h"

Nit: this should go before |#include "nsComponentManagerUtils.h"|

::: dom/indexedDB/IDBRequest.h
@@ +6,5 @@
>  
>  #ifndef mozilla_dom_indexeddb_idbrequest_h__
>  #define mozilla_dom_indexeddb_idbrequest_h__
>  
> +

Nit: remove this empty line

@@ +19,1 @@
>  #include "mozilla/dom/DOMError.h"

#include "mozilla/dom/indexedDB/IndexedDatabase.h"

#include "mozilla/Attributes.h"
#include "mozilla/dom/DOMError.h"
#include "mozilla/dom/IDBRequestBinding.h"
#include "mozilla/ErrorResult.h"
#include "nsCycleCollectionParticipant.h"
#include "nsWrapperCache.h"

#include "mozilla/dom/indexedDB/IDBWrapperCache.h"

@@ +116,5 @@
> +  GetResult(JSContext* aCx, ErrorResult& aRv) const;
> +
> +  nsISupports*
> +  GetSource() const
> +  {

add the main thread assertion, here and below

::: dom/indexedDB/ipc/IndexedDBParent.cpp
@@ +383,5 @@
>  
>    AutoSafeJSContext cx;
>  
> +  ErrorResult error;
> +  JS::Value result = mOpenRequest->GetResult(cx, error);

Is this safe ?

I would expect something like:
JS::Rooted<JS::Value> result ...
Attachment #783691 - Flags: review?(Jan.Varga)
Created attachment 783798 [details] [diff] [review]
request.patch
Attachment #783691 - Attachment is obsolete: true
Attachment #783798 - Flags: review?(Jan.Varga)

Comment 4

4 years ago
Comment on attachment 783798 [details] [diff] [review]
request.patch

r=me
Attachment #783798 - Flags: review?(Jan.Varga) → review+
Duplicate of this bug: 888599
https://hg.mozilla.org/integration/mozilla-inbound/rev/023d2f835ca0
Keywords: dev-doc-needed
IDBRequest.LOADING and IDBRequest.DONE are gone. Documentation must be updated.
https://hg.mozilla.org/mozilla-central/rev/023d2f835ca0
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
https://developer.mozilla.org/en-US/docs/Web/API/IDBRequest#Constants
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility
Keywords: dev-doc-needed → addon-compat, dev-doc-complete, site-compat
OS: Mac OS X → All
Hardware: x86 → All
Depends on: 1142210
You need to log in before you can comment on or make changes to this bug.