887536 - [socorro-crashstats] UnboundLocalError: local variable 'version' referenced before assignment

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Not sure why we don't see this on prod, but it might have something to do with which versions are available/enabled, etc.

STR:

Load https://crash-stats-django.allizom.org/crash_trends/products/Firefox

Actual:

UnboundLocalError: local variable 'version' referenced before assignment

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "crashstats/crashstats/decorators.py", line 48, in inner
    return view(request, *args, **kwargs)
  File "crashstats/crashstats/views.py", line 1608, in crash_trends
    context['version'] = version

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

See https://errormill.mozilla.org/webtools/socorro-crashstats-stage/group/16581/ for more.

Comment 2

[Robert Helmer [:rhelmer]]

Hmm that's odd, works locally pointing to dev too.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

This is happening in production (at least right now); see https://bugzilla.mozilla.org/show_bug.cgi?id=914933#c0

Comment 4

[Schalk Neethling [:espressive]]

Resolving this as part of https://bugzilla.mozilla.org/show_bug.cgi?id=909930

Comment 5

[Schalk Neethling [:espressive]]

https://github.com/mozilla/socorro/pull/1498

Comment 6

[Schalk Neethling [:espressive]]

The best and simplest way to test this, is to use the products from Comment 1 and ensure that these products no longer return a 500 error but now, the page loads successfully and there is a message provided to the user that there was no data found for the provided criteria.

Also, the versions will try to load but, if there are no Nightly versions at all, a message will also be shown above the form stating that no versions was found for the product.

Comment 7

[Schalk Neethling [:espressive]]

Fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=909930