Closed Bug 88757 Opened 24 years ago Closed 23 years ago

ASSERTION: nsInstallProgressDialog not thread-safe

Tracking

(Not tracked)

Status:

VERIFIED FIXED

Milestone:

Future

People

(Reporter: timeless, Assigned: dveditz)

Details

(Keywords: assertion)

timeless

Reporter

Description

•

24 years ago

m092branch last updated a few days ago (after failed branch rc, before branch gm) no interesting patches applied. [w2k, msvc6?, psm2] steps: try to install chatzilla0.8.3 from hacksrus.com, (install link), select ok, watch progress, it finished (?) get assert I don't have a live browser because it's asserting, here's the console spew which should imply url/link: Error loading URL http://www.hacksrus.com/~ginda/chatzilla : 2152398850 WEBSHELL+ = 4 Disabling Quirk StyleSheet Adding element 0 : _blank /content/xpinstall/institems.xul WEBSHELL- = 3 WEBSHELL+ = 4 Error loading URL javascript:install("chatzilla", "chatzilla-0.8.3.xpi"); : 2152924149 here's the assert: ###!!! ASSERTION: nsInstallProgressDialog not thread-safe: 'owningThread == NS_CurrentThread()', file F:\build\beonex\mozilla\xpcom\base\nsDebug.cpp, line 528 ###!!! Break: at file F:\build\beonex\mozilla\xpcom\base\nsDebug.cpp, line 528 and the callstack NTDLL! 77fa018c() nsDebug::Assertion(const char * 0x04fc999c, const char * 0x100e332c, const char * 0x100e32fc, int 528) line 290 + 13 bytes NS_CheckThreadSafe(void * 0x00482bf0, const char * 0x04fc999c) line 528 + 34 bytes nsInstallProgressDialog::AddRef(nsInstallProgressDialog * const 0x04b999b0) line 59 + 55 bytes nsInstallProgressDialog::QueryInterface(nsInstallProgressDialog * const 0x04b999b0, const nsID & {...}, void * * 0x054dfd08) line 85 nsQueryInterface::operator()(const nsID & {...}, void * * 0x054dfd08) line 32 + 25 bytes nsCOMPtr_base::assign_from_helper(const nsCOMPtr_helper & {...}, const nsID & {...}) line 65 + 18 bytes nsCOMPtr<nsISupports>::nsCOMPtr<nsISupports>(const nsCOMPtr_helper & {...}) line 802 nsProxyEventObject::~nsProxyEventObject() line 385 nsProxyEventObject::`scalar deleting destructor'(unsigned int 1) + 15 bytes nsProxyEventObject::Release(nsProxyEventObject * const 0x04b6d4f0) line 400 + 133 bytes nsProxyEventObject::~nsProxyEventObject() line 396 + 27 bytes nsProxyEventObject::`scalar deleting destructor'(unsigned int 1) + 15 bytes nsProxyEventObject::Release(nsProxyEventObject * const 0x04b6f650) line 400 + 133 bytes nsCOMPtr<nsIXPIProgressDlg>::assign_assuming_AddRef(nsIXPIProgressDlg * 0x00000000) line 472 nsCOMPtr<nsIXPIProgressDlg>::assign_with_AddRef(nsISupports * 0x00000000) line 964 nsCOMPtr<nsIXPIProgressDlg>::operator=(nsIXPIProgressDlg * 0x00000000) line 584 nsXPInstallManager::Shutdown() line 534 nsXPInstallManager::AfterJavascriptEvaluation(nsXPInstallManager * const 0x044c2b40, const unsigned short * 0x052ee100) line 882 nsTopProgressListener::AfterJavascriptEvaluation(nsTopProgressListener * const 0x052ee060, const unsigned short * 0x052ee100) line 114 RunInstallOnThread(void * 0x052ee1b0) line 504 _PR_NativeRunThread(void * 0x052f64a0) line 399 + 13 bytes _threadstartex(void * 0x052f6900) line 212 + 13 bytes

Doug Turner (:dougt)