887591 - "Custom VIVO configuration Test Suite" fails on TBPL

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Jonathan Griffin (:jgriffin)]

The gaia unit test "Custom VIVO configuration Test Suite" frequently fails on TBPL; we'll need to disable if it can't be fixed quickly.

https://tbpl.mozilla.org/php/getParsedLog.php?id=24638140&tree=Cedar&full=1#error0

17:02:15     INFO -  gaia-unit-tests TEST-UNEXPECTED-FAIL | Custom VIVO configuration Test Suite > Balance request matches the proper pattern | expected false to be true
17:02:15     INFO -  gaia-unit-tests INFO       | stack trace:
17:02:15     INFO -      Error: expected false to be true
17:02:15     INFO -          at chaiAssert (http://test-agent.gaiamobile.org:8080/common/test/helper.js:30)
17:02:15     INFO -          at get (http://test-agent.gaiamobile.org:8080/common/vendor/chai/chai.js:374)
17:02:15     INFO -          at isTrue (http://test-agent.gaiamobile.org:8080/common/vendor/chai/chai.js:1367)
17:02:15     INFO -          at assertIsTime (http://costcontrol.gaiamobile.org:8080/test/unit/vivo_config_test.js:59)
17:02:15     INFO -          at (anonymous) (http://costcontrol.gaiamobile.org:8080/test/unit/vivo_config_test.js:77)
17:02:15     INFO -          at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:62)
17:02:15     INFO -          at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
17:02:15     INFO -          at runTest (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081)
17:02:15     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127)
17:02:15     INFO -          at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007)
17:02:15     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016)
17:02:15     INFO -          at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964)
17:02:15     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
17:02:15     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)

Comment 1

[Julien Wajsberg [:julienw]]

Fails sometimes in travis too, see https://travis-ci.org/mozilla-b2g/gaia/builds/8487779

Salva, any thought ? Is it possible that some "time" values are not correctly tested (for example, if there is only one digit in one of the fields) ?

Comment 2

[Salvador de la Puente González [:salva]]

Attachment: Fixing time assertions

Comment 3

[Salvador de la Puente González [:salva]]

You were totally right Julien. This patch not only fixes the assertion problems but it controls the today date. Thanks for the clue!

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 768212 [details]
Fixing time assertions

r=me with the nit

thanks !

Comment 5

[Salvador de la Puente González [:salva]]

Master: 350fdbdf347523026673d3d1b34cda92a9273d47