887593 - BadStatusCodeError: 500 on /bpapi/crashes/paireduuid

Status: VERIFIED FIXED

(Socorro Graveyard :: Middleware, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

When I hit https://crash-stats-django.allizom.org/report/index/f9c7cdd6-c789-4d88-9ec2-8833c2130626, we get:

BadStatusCodeError: 500: on: http://socorro-mware-stage-zlb.webapp.phx1.mozilla.com/bpapi/crashes/paireduuid/crash_id/f9c7cdd6-c789-4d88-9ec2-8833c2130626/hang_id/9644fd03-6ce1-482b-9336-4b52b6783547/

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "crashstats/crashstats/decorators.py", line 48, in inner
    return view(request, *args, **kwargs)
  File "crashstats/crashstats/views.py", line 844, in report_index
    hang_id=context['hang_id']
  File "crashstats/crashstats/models.py", line 234, in get
    return self.fetch(url % params, expect_json=expect_json)
  File "crashstats/crashstats/models.py", line 139, in fetch
    raise BadStatusCodeError('%s: on: %s' % (resp.status_code, url))

Comment 1

[Robert Helmer [:rhelmer]]

Seems to be something specific to this crash - I pulled it from stage and re-submitted to dev, got this stack trace from the middleware:

[Wed Jun 26 18:19:38 2013] [error] [client 10.2.72.11] Traceback (most recent call last):
[Wed Jun 26 18:19:38 2013] [error] [client 10.2.72.11]   File "/data/socorro/thirdparty/web/application.py", line 237, in process
[Wed Jun 26 18:19:38 2013] [error] [client 10.2.72.11]     return self.handle()
[Wed Jun 26 18:19:38 2013] [error] [client 10.2.72.11]   File "/data/socorro/thirdparty/web/application.py", line 228, in handle
[Wed Jun 26 18:19:38 2013] [error] [client 10.2.72.11]     return self._delegate(fn, self.fvars, args)
[Wed Jun 26 18:19:38 2013] [error] [client 10.2.72.11]   File "/data/socorro/thirdparty/web/application.py", line 394, in _delegate
[Wed Jun 26 18:19:38 2013] [error] [client 10.2.72.11]     return handle_class(f)
[Wed Jun 26 18:19:38 2013] [error] [client 10.2.72.11]   File "/data/socorro/thirdparty/web/application.py", line 385, in handle_class
[Wed Jun 26 18:19:38 2013] [error] [client 10.2.72.11]     return tocall(*args)
[Wed Jun 26 18:19:38 2013] [error] [client 10.2.72.11]   File "/data/socorro/application/socorro/webapi/webapiService.py", line 74, in GET
[Wed Jun 26 18:19:38 2013] [error] [client 10.2.72.11]     raise web.webapi.BadRequest(message=str(e))
[Wed Jun 26 18:19:38 2013] [error] [client 10.2.72.11] TypeError: __init__() got an unexpected keyword argument 'message'
[Wed Jun 26 18:19:38 2013] [error] [client 10.2.72.11] 
[Wed Jun 26 18:19:39 2013] [error] [client 10.2.72.11] Traceback (most recent call last):
[Wed Jun 26 18:19:39 2013] [error] [client 10.2.72.11]   File "/data/socorro/thirdparty/web/application.py", line 237, in process
[Wed Jun 26 18:19:39 2013] [error] [client 10.2.72.11]     return self.handle()
[Wed Jun 26 18:19:39 2013] [error] [client 10.2.72.11]   File "/data/socorro/thirdparty/web/application.py", line 228, in handle
[Wed Jun 26 18:19:39 2013] [error] [client 10.2.72.11]     return self._delegate(fn, self.fvars, args)
[Wed Jun 26 18:19:39 2013] [error] [client 10.2.72.11]   File "/data/socorro/thirdparty/web/application.py", line 394, in _delegate
[Wed Jun 26 18:19:39 2013] [error] [client 10.2.72.11]     return handle_class(f)
[Wed Jun 26 18:19:39 2013] [error] [client 10.2.72.11]   File "/data/socorro/thirdparty/web/application.py", line 385, in handle_class
[Wed Jun 26 18:19:39 2013] [error] [client 10.2.72.11]     return tocall(*args)
[Wed Jun 26 18:19:39 2013] [error] [client 10.2.72.11]   File "/data/socorro/application/socorro/webapi/webapiService.py", line 74, in GET
[Wed Jun 26 18:19:39 2013] [error] [client 10.2.72.11]     raise web.webapi.BadRequest(message=str(e))
[Wed Jun 26 18:19:39 2013] [error] [client 10.2.72.11] TypeError: __init__() got an unexpected keyword argument 'message'
[Wed Jun 26 18:19:39 2013] [error] [client 10.2.72.11]

Comment 2

[Robert Helmer [:rhelmer]]

This does work on the PHP app - here's the crash I inserted:

https://crash-stats-dev.allizom.org/report/index/8367dd04-6f78-4681-87f2-35b1b2130627

Comment 3

[Robert Helmer [:rhelmer]]

I think there are two parts to this - one is the mware, here's the code it's the above is throwing for (File "/data/socorro/application/socorro/webapi/webapiService.py", line 74):

        except MissingOrBadArgumentError, e:
            raise web.webapi.BadRequest(message=str(e))

So the django app is sending a missing or bad argument, but also the mware is using an inappropriate "message" keyword argument and so is eating the exception :/

Adrian can you fix this on the mware side, I will file a separate bug for the django app?

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro/pull/1319

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/f8262878f3cf044a6163ba1ee604460746cc36bb
Fixes bug 887593 - Make BadRequest raise an error message.

https://github.com/mozilla/socorro/commit/339320d385e75500e4ee472a26642da37f8e0415
Merge pull request #1319 from AdrianGaudebert/887593

Fixes bug 887593 - Make BadRequest raise an error message.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx, verified FIXED:

[15:09:31.125] GET https://crash-stats-django.allizom.org/report/index/f9c7cdd6-c789-4d88-9ec2-8833c2130626 [HTTP/1.1 200 OK 596ms]