Closed Bug 887669 Opened 8 years ago Closed 8 years ago

[Test][System] Unit test for Permission Manager

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alive, Assigned: gasolin)

References

Details

Attachments

(1 file)

Note: there's two open bugs to change permission into mozbrowser API:
Bug 853711 - [Permission] Gaia fix of bug 852013: Move permission dialog into appWindow and bind to BrowserFrame
Bug 852013 - Send PermissionRequestEvent from mozbrowser iframe, instead of mozChromeEvent (edit)

But they are not under any plan now.
Assignee: nobody → gasolin
would like to change the format from 

var PermissionManager = (function() { }()); 

to test friendly literal object format

var PermissionManager = {}; PermissionManager.init()
Finally I prefer to have permission dialog to be app-specific(Multi-instances). But in this stage, turn module pattern into literal object is acceptable. Thanks!
WIP: have migrated to literal object format and works well. Starting write test cases
test ChromeEvents and first-level handlers
Attachment #800028 - Flags: review?(alive)
Comment on attachment 800028 [details]
pull request redirect to github

r=me if you move all PermissionManager reference to this or self.
Attachment #800028 - Flags: review?(alive) → review+
Blocks: 907075
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/cf6272fc46bfe4aa636725869c2a5685a4c33ea3

thanks!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.