887764 - [User Story] Ending a conference call

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Wilfred Mathanaraj [:WDM]]

User story:

As a conf call creator I expect the conf call to end when I hang up the call. And as a normal participant in a conference call I expect to hang up and the conf call not to end.

This user story should have already been implemented but included for completion and confirmation of functionality.

Preconditions:

* Dialer app is open
* a conference call is already ongoing


Acceptance Criteria:

* if conference call creator hangs up the call the conference call is ended without users getting any other special notification than the call ending
* if a participant in a conf call hangs up then the conference call continues without ans interruption

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

listed as must have in v1.2 for COMM team. koi+

Comment 2

[Al Tsai [:atsai]]

MozTrap #9057, #9059

Comment 3

[Stephany Wilkes]

Hi team. As we get started on conference call specs, we know the spec will show how to end a call and what happens during that time. 

In this document:
https://mozilla.app.box.com/files/0/f/809825975/1/f_8112068714

There are notes from meetings with UX, Eng and Product (Krishna at the time), and the notes say that this user story (about ending the call) has the same issue as the user story as seeing information about call participants (see 887686). At the time, it sounded like it was only technically feasible to see the last active call (not who it is) and that the creator ending the call would end it for all participants.

Are these notes still accurate, or have things changed? Just want to make sure our specs reflect technical reality as early on as possible. Thanks!

Comment 4

[Wilfred Mathanaraj [:WDM]]

This bug specifically covers only the ending of a call - and this is our understanding:

as a creator if you end call the conference calls ends for all.

Comment 5

[Etienne Segonzac (:etienne)]

This already landed as part of bug 906775 [1]

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/calls_handler.js#L615-618

Comment 6

[Etienne Segonzac (:etienne)]

Attachment: Follow up gaia PR

Found an edge case, here is a fix.

Comment 7

[Anthony Ricaud (:rik)]

Comment on attachment 804321 [details]
Follow up gaia PR

I wish we could test this but it's a bit tricky so r+.

Comment 8

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/77650407e40411897ee588481daceb4da465345e