887769 - Handling of modal-dialog can fail with 'this._timer is null' if application gets shutdown

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

When I run our restart tests with Mozmill 2.0 I can see the following failure popping up when the application goes down:

CRITICAL | Framework Failure | {
  "message": "[JavaScript Error: \"this._timer is null\" {file: \"resource://mozmill/stdlib/securable-module.js -> file:///c:/mozilla/mozmill-tests/lib/modal-dialog.js\" line: 128}]"
}

We should protect such code by checking if the timer is still alive.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Actually this is not right. The problem happens when we run the restartTests/testAddons_installFromFTP test. As I can see I cannot reach the FTP server from inside this Win8 VM, so a modal dialog instantiated before, causes the problem in combination with an assertion of a timeout in waitForPageLoad().

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

Comment 3

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 773878 [details] [diff] [review]
Patch v1

Review of attachment 773878 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed on default as:
http://hg.mozilla.org/qa/mozmill-tests/rev/e573f1592669

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

http://hg.mozilla.org/qa/mozmill-tests/rev/43a6a8a9beb6 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/9f7980a5bb10 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/a34533f648bc (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/893b0a62af75 (esr17)