887907 - Switch OS.File to Promise.jsm

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[Gregory Szorc [:gps]]

OS.File currently can't run on B2G because promise.js isn't available because it's part of the add-on sdk. I'm hoping switching OS.File to Promise.jsm (which will be done in the long run anyway) will fix it.

Comment 1

[Gregory Szorc [:gps]]

I might have been wrong about promise.js availability on b2g. Although, we are seeing an xpcshell test failure in /services/healthreport that appears to be cu.import complaining about missing addons.js. Strangely the os.file xpcshell tests are passing!

Comment 2

[Gregory Szorc [:gps]]

I obviously meant missing "promise.js," not "addons.js."

Comment 3

[David Teller [:Yoric] - still alive but not very active]

FWIW, OS.File has worked on B2G and promise.js (or promise/core.js, at least) used to be available for B2G. But yes, by all means, let's move to Promise.jsm.

Comment 4

[Stefan Mirea [:smirea]]

Attachment: move OS.File to use Promise.jsm

Changed 2 files and one test to use Promise.jsm instead of promise.js. On my configuration tests worked without any other modification on boot 2 gecko. needs push to try

Comment 5

[Gregory Szorc [:gps]]

Turns out the B2G bit was completely wrong.

Comment 6

[Gregory Szorc [:gps]]

https://tbpl.mozilla.org/?tree=Try&rev=c3ef244405ca

I'm guessing more failures than Task.jsm (bug 887923) because OS.File is more widely used.

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 768454 [details] [diff] [review]
move OS.File to use Promise.jsm

Review of attachment 768454 [details] [diff] [review]:
-----------------------------------------------------------------

Surprisingly, this didn't appear to introduce any new failures!

Comment 8

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/36075e85ce59

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/36075e85ce59