887909 - Convert nsIIDBFileHandle.idl to IDBFileHandle.webidl

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Jan Varga [:janv]]

It seems that FileHandle objects returned by IDB lost the .database attribute after conversion to new DOM bindings.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 2

[Jan Varga [:janv]]

Comment on attachment 768835 [details] [diff] [review]
Patch v1

Review of attachment 768835 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, r=me (consider fixing the nits)

::: dom/indexedDB/IDBFileHandle.cpp
@@ +34,5 @@
>  }
>  
>  } // anonymous namespace
>  
> +/* virtual */ JSObject*

Nit: "// virtual" and JSObject* on a new line

@@ +110,5 @@
>  {
>    NS_ASSERTION(NS_IsMainThread(), "Wrong thread!");
>  
> +  IDBDatabase* database = static_cast<IDBDatabase*>(mFileStorage);
> +  MOZ_ASSERT(database);

Nit: I would keep the empty line here

::: dom/indexedDB/IDBFileHandle.h
@@ +22,1 @@
>  

Nit: WrapObject() on a new line, like all the other methods

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/a789c48ae599