887911 - Improve localization comment for zoom-reset-button.label (customizableWidgets.properties)

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Francesco Lodolo [:flod]]

String introduced in bug 887853 (see also URL)

# LOCALIZATION NOTE(zoom-reset-button.label): %S is the current zoom level.
zoom-reset-button.label = %S%%

The localization note should explain the reason for these many "%", so that localizers won't delete them by mistake.

Example.

# LOCALIZATION NOTE(zoom-reset-button.label): %S is the current zoom level,
# %% will be displayed as a single % characters (a single % is used to
# define format specifiers).

Comment 1

[Francesco Lodolo [:flod]]

Slightly improved

# LOCALIZATION NOTE(zoom-reset-button.label): %S is the current zoom level,
# %% will be displayed as a single % character (% is commonly used to define
# format specifiers, so it needs to be escaped).

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Patch improving l10n comment

Comment 3

[Francesco Lodolo [:flod]]

Attachment: (real) Patch improving l10n comment

Comment 4

[:Gijs (he/him)]

Comment on attachment 768493 [details] [diff] [review]
(real) Patch improving l10n comment

r=me

I'm not sure if you left the review field blank because we already talked on IRC, if so disregard this, but otherwise: it is usually helpful to pick someone to review a patch - if they are unable to review the code they'll usually ping someone else. :-)

Comment 5

[:Gijs (he/him)]

Pushed, https://hg.mozilla.org/projects/ux/rev/48544f26c061

Comment 6

[Francesco Lodolo [:flod]]

(In reply to :Gijs Kruitbosch from comment #4)
> I'm not sure if you left the review field blank because we already talked on
> IRC, if so disregard this, but otherwise: it is usually helpful to pick
> someone to review a patch

Plan was to not set the flag at all because I couldn't find you on bugzilla (was searching for "gijs" instead of ":gijs"), and to correct it later. Didn't realize I left it to "?" without reviewer (didn't even know it's possible).

Thanks for the push and the support on IRC today.

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/48544f26c061