Closed
Bug 887930
Opened 11 years ago
Closed 11 years ago
[fig] Open in New Tab from context menu switches to tab
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 26
People
(Reporter: capella, Assigned: capella)
References
Details
(Whiteboard: fixed-fig)
Attachments
(1 file)
1.14 KB,
patch
|
sriram
:
review+
Margaret
:
feedback+
|
Details | Diff | Splinter Review |
Pretty simple ... long tap Visited or Bookmark item, select Open in new Tab and we open and switch to the tab, versus staying where we are, allowing further actions. Not sure how much of the new design is intentional or otherwise, so I'm quick posting the report, and a fix.
Assignee | ||
Updated•11 years ago
|
Summary: Open in New Tab from context menu switches to tab → [fig] Open in New Tab from context menu switches to tab
Comment 1•11 years ago
|
||
Comment on attachment 768482 [details] [diff] [review] Patch (v1) This sounds like a smart fix to me. This was probably just an oversight when moving the existing code over. Sriram added this code so let's let him review it :)
Attachment #768482 -
Attachment is patch: true
Attachment #768482 -
Flags: review?(sriram)
Attachment #768482 -
Flags: feedback+
Updated•11 years ago
|
Assignee: nobody → markcapella
Comment 2•11 years ago
|
||
Comment on attachment 768482 [details] [diff] [review] Patch (v1) Review of attachment 768482 [details] [diff] [review]: ----------------------------------------------------------------- Sounds right to me. I was copying code from BrowserApp which probably didnt require that argument.
Attachment #768482 -
Flags: review?(sriram) → review+
Assignee | ||
Comment 3•11 years ago
|
||
first patch with the new toy :) http://hg.mozilla.org/projects/fig/rev/5bf7fd5d6675
Whiteboard: fixed-fig
Comment 4•11 years ago
|
||
(In reply to Mark Capella [:capella] from comment #3) > first patch with the new toy :) > > http://hg.mozilla.org/projects/fig/rev/5bf7fd5d6675 \o/
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5bf7fd5d6675
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Comment 6•10 years ago
|
||
Verified as fixed on builds: Nightly (2014-05-16) Aurora (2014-05-16) Beta 30.0 Release 29.0.1 Device: Asus Transformer Pad TF300T (Android 4.2.1)
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•