887930 - [fig] Open in New Tab from context menu switches to tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Capella [:capella]]

Attachment: Patch (v1)

Pretty simple ... long tap Visited or Bookmark item, select Open in new Tab and we open and switch to the tab, versus staying where we are, allowing further actions.

Not sure how much of the new design is intentional or otherwise, so I'm quick posting the report, and a fix.

Comment 1

[:Margaret Leibovic]

Comment on attachment 768482 [details] [diff] [review]
Patch (v1)

This sounds like a smart fix to me. This was probably just an oversight when moving the existing code over.

Sriram added this code so let's let him review it :)

Comment 2

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 768482 [details] [diff] [review]
Patch (v1)

Review of attachment 768482 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds right to me. I was copying code from BrowserApp which probably didnt require that argument.

Comment 3

[Mark Capella [:capella]]

first patch with the new toy :)

http://hg.mozilla.org/projects/fig/rev/5bf7fd5d6675

Comment 4

[:Margaret Leibovic]

(In reply to Mark Capella [:capella] from comment #3)
> first patch with the new toy :)
> 
> http://hg.mozilla.org/projects/fig/rev/5bf7fd5d6675

\o/

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5bf7fd5d6675

Comment 6

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed on builds:

Nightly (2014-05-16)
Aurora (2014-05-16)
Beta 30.0
Release 29.0.1

Device:
Asus Transformer Pad TF300T (Android 4.2.1)