887972 - Allow user to select profiled threads in addon

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Bug 873914 added backend code to filter profiled threads. We should expose that functionality to the user.

Also need to cover the case when threads are filtered and a new thread spawns. The user should be able to decide whether to profile this new thread or not.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add threadfilter feature to list of profiler features (v1)

This patch adds 'threadfilter' to the list of supported features, which makes it easy for the add-on to detect support for thread name filters.

See https://github.com/bgirard/Gecko-Profiler-Addon/pull/50

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 770232 [details] [diff] [review]
Add threadfilter feature to list of profiler features (v1)

Review of attachment 770232 [details] [diff] [review]:
-----------------------------------------------------------------

I think it would be fine to not add this and not care about the builds where we support multi-thread but not filtering but I'm fine with taking this.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

The Gecko change is not needed with the updated code.

https://github.com/bgirard/Gecko-Profiler-Addon/commit/44fdb75567f110adafe95d9dd5d520b1cddae110