888033 - Change - add a pref to disable navigation handles

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect, P2)

Description

[juan becerra [:juanb]]

Tested on 2013-06-27 using latest nightly.

The <- and + handles on the edges of the Firefox Metro screen can feel a little intrusive, and more often than not I find myself wanting them to be off.

Could we add an about:config pref or a toggle setting in the options flyout that would allow the user to disable these?

Comment 1

[Jim Mathies [:jimm]]

Attachment: fix

Comment 2

[Allison Naaktgeboren :ally]

Comment on attachment 768887 [details] [diff] [review]
fix

Review of attachment 768887 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/NavButtonSlider.js
@@ +84,5 @@
> +      this._back.setAttribute("hidden", true);
> +      this._plus.setAttribute("hidden", true);
> +    }
> +  },
> + 

nit: whitespace

::: browser/metro/profile/metro.js
@@ +91,5 @@
>  pref("network.protocol-handler.warn-external.ms-windows-store", false);
>  pref("network.protocol-handler.external.ms-windows-store", true);
>  
> +// display the overlay nav buttons
> +pref("browser.display.navbuttons", true);

nit: I'm a bit worried that this name is not specific enough, there are many nav buttons in the browser afterall. However, I don't see anything that it could be confused with in classic about:config or metro's, so we can leave it if no stroke of brilliant nomenclature hits before committing.

Comment 3

[Jim Mathies [:jimm]]

This pref has been updated to "browser.display.overlaynavbuttons".

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0f10e9f06323

Comment 5

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.2; rv:25.0) Gecko/20130715 Firefox/25.0

Verified this on latest nightly build.
The navigation handles can be disabled by setting the "browser.display.overlaynavbuttons" pref to false in about:config.

Comment 6

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130816030205
Built from http://hg.mozilla.org/mozilla-central/rev/1ed5a88cd4d0

WFM
Tested on windows 8 using latest nightly for iteration-12. The navigation handles can be disabled by setting the "browser.display.overlaynavbuttons" pref to false in about:config.