Closed Bug 888033 Opened 7 years ago Closed 7 years ago

Change - add a pref to disable navigation handles

Categories

(Firefox for Metro Graveyard :: General, defect, P2)

x86
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 25

People

(Reporter: jbecerra, Assigned: jimm)

References

Details

(Whiteboard: feature=change c=tbd u=tbd p=1)

Attachments

(1 file)

Tested on 2013-06-27 using latest nightly.

The <- and + handles on the edges of the Firefox Metro screen can feel a little intrusive, and more often than not I find myself wanting them to be off.

Could we add an about:config pref or a toggle setting in the options flyout that would allow the user to disable these?
Summary: change - add a pref to disable navigation handles → Change - add a pref to disable navigation handles
Whiteboard: feature=change c=tbd u=tbd p=0
Attached patch fixSplinter Review
Assignee: nobody → jmathies
Attachment #768887 - Flags: review?(ally)
Whiteboard: feature=change c=tbd u=tbd p=0 → feature=change c=tbd u=tbd p=1
OS: Mac OS X → Windows 8 Metro
Blocks: metrov1it10
No longer blocks: metrov1defect&change
Status: NEW → ASSIGNED
QA Contact: jbecerra
Priority: -- → P2
Comment on attachment 768887 [details] [diff] [review]
fix

Review of attachment 768887 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/NavButtonSlider.js
@@ +84,5 @@
> +      this._back.setAttribute("hidden", true);
> +      this._plus.setAttribute("hidden", true);
> +    }
> +  },
> + 

nit: whitespace

::: browser/metro/profile/metro.js
@@ +91,5 @@
>  pref("network.protocol-handler.warn-external.ms-windows-store", false);
>  pref("network.protocol-handler.external.ms-windows-store", true);
>  
> +// display the overlay nav buttons
> +pref("browser.display.navbuttons", true);

nit: I'm a bit worried that this name is not specific enough, there are many nav buttons in the browser afterall. However, I don't see anything that it could be confused with in classic about:config or metro's, so we can leave it if no stroke of brilliant nomenclature hits before committing.
Attachment #768887 - Flags: review?(ally) → review+
This pref has been updated to "browser.display.overlaynavbuttons".
https://hg.mozilla.org/mozilla-central/rev/0f10e9f06323
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Mozilla/5.0 (Windows NT 6.2; rv:25.0) Gecko/20130715 Firefox/25.0

Verified this on latest nightly build.
The navigation handles can be disabled by setting the "browser.display.overlaynavbuttons" pref to false in about:config.
Status: RESOLVED → VERIFIED
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130816030205
Built from http://hg.mozilla.org/mozilla-central/rev/1ed5a88cd4d0

WFM
Tested on windows 8 using latest nightly for iteration-12. The navigation handles can be disabled by setting the "browser.display.overlaynavbuttons" pref to false in about:config.
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.