Closed Bug 888067 Opened 11 years ago Closed 11 years ago

Defect - Combined bar shouldnt appear on the js error console panel

Categories

(Firefox for Metro Graveyard :: General, defect, P2)

x86_64
Windows 8
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ally, Assigned: jwilde)

References

Details

(Whiteboard: feature=defect c=tbd u=tbd p=1)

Attachments

(2 files, 1 obsolete file)

was not on yesterday's build.

also of note: the bar won't dismiss.
Summary: combined bar shouldnt appear on the js error console panel → Defect - Combined bar shouldnt appear on the js error console panel
Whiteboard: feature=defect c=tbd u=tbd p=0
This only happens if the startpage is visible when you invoke the console. If you open from a web site it falls away. This due to a left over "startpage".
Attached patch fix (obsolete) — Splinter Review
Assignee: nobody → jmathies
Attachment #768883 - Flags: review?(jwilde)
Whiteboard: feature=defect c=tbd u=tbd p=0 → feature=defect c=tbd u=tbd p=1
Blocks: metrov1it10
No longer blocks: metrov1defect&change
QA Contact: jbecerra
Status: NEW → ASSIGNED
Priority: -- → P2
Assignee: jmathies → jwilde
Comment on attachment 768883 [details] [diff] [review]
fix

Review of attachment 768883 [details] [diff] [review]:
-----------------------------------------------------------------

We really should just move the position of the panel UI in terms of z-index rather than adding extra logic to PanelUI. I'll go make the second patch for this. :D
Attachment #768883 - Flags: review?(jwilde)
Attached patch fix v2Splinter Review
updating the dom z-order instead of updating panelui
Attachment #768883 - Attachment is obsolete: true
Attachment #769154 - Flags: review?(jmathies)
Attachment #769154 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/3029d3574f2e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
User Agent : Mozilla/5.0 (Windows NT 6.2; WOW64; rv:25.0) Gecko/20130712 Firefox/25.0

Verified as fixed on latest nightly build.
The combined url/appbar is not shown anymore on the js error console panel.
Status: RESOLVED → VERIFIED
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130816030205
Built from http://hg.mozilla.org/mozilla-central/rev/1ed5a88cd4d0

WFM
Tested on windows 8 using latest nightly for iteration-12. The combined url/appbar is not shown anymore on the js error console panel.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: