888201 - java.lang.NullPointerException: at org.mozilla.gecko.GeckoApp.collectAndReportLocInfo(GeckoApp.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It has been hit three times by a single user in 25.0a1/20130626. Here is a crash report: bp-dc834ab4-027a-4b45-b37d-a03cb2130628.
It's likely a regression from bug 866957.

java.lang.NullPointerException
	at org.mozilla.gecko.GeckoApp.collectAndReportLocInfo(GeckoApp.java:2427)
	at org.mozilla.gecko.GeckoApp.onLocationChanged(GeckoApp.java:2300)
	at org.mozilla.gecko.GeckoAppShell$3.run(GeckoAppShell.java:467)
	at android.os.Handler.handleCallback(Handler.java:615)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4849)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:795)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:562)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?product=FennecAndroid&signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.GeckoApp.collectAndReportLocInfo%28GeckoApp.java%29

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 768954 [details] [diff] [review]
patch

Review of attachment 768954 [details] [diff] [review]:
-----------------------------------------------------------------

While mashing them together on a single line is pretty neat I'd prefer to do the right thing and stick in a newline and braces so other people don't copy this pattern to places it doesn't belong.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 768954 [details] [diff] [review]
patch

pushed to inbound

trivial null check fix. Should uplift to aurora which is where this code appeared.

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/df05a19f8be3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7568be854b65