888206 - [Cost Control] Start-up process crashes trying to load an nonexistent balance configuration causing settings UI to crash as well.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P1)

Description

[Zac C (:zac)]

Attachment: screenshot

All the string content is missing from the Settings in Cost Control app making it unusable.


Gecko  http://hg.mozilla.org/mozilla-central/rev/3b955f306226
Gaia  b9a009103bd70ec77eb8ec9472a943e38d8219b1
BuildID 20130627031208
Version 25.0a1

Comment 1

[Salvador de la Puente González [:salva]]

Please, can you report a STR?

Comment 2

[Zac C (:zac)]

I am not sure how to give you STR aside from:

1. Load Usage app
2. Complete Usage FTE
3. Open settings!

I even re-flashed my device just to see if there was something wrong but on a fresh flash it still had the same problem.

Comment 3

[Salvador de la Puente González [:salva]]

Gaia master?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Salvador de la Puente González [:salva] from comment #3)
> Gaia master?

Yep, Gaia master.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

I think this is related to a localized bug that window.onlocalized is not fired. If I comment out the line 189 to 192 in [1], I get the same result as attachment. It's an old bug and I got the bug number. I will post bug number back if I found it.

[1] https://github.com/mozilla-b2g/gaia/blob/6e78863eeff44198e76fae6ef501f9cb073e194e/apps/costcontrol/js/app.js#L189-L192

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

I got it, it is bug 882592. Ian Liu found this bug that the window.localized is not fired when event listener is hooked after window is already localized, and the event is never fired anymore. It's a race condition. So, it is hard to reproduce.

Comment 7

[Salvador de la Puente González [:salva]]

From comment 6, adding bug 882592 as blocker.

Comment 8

[Salvador de la Puente González [:salva]]

No, this is not related with bug 882592. Rewording and preparing a PR.

Comment 9

[Salvador de la Puente González [:salva]]

This is a regression introduced by bug 885314. Please, flag as a blocker as it is a regression.

Comment 10

[Salvador de la Puente González [:salva]]

Attachment: Avoid crash during start-up

Comment 11

[Leo]

Bug 885314 is dependent on this issue.So marking it as leo+.

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 770201 [details]
Avoid crash during start-up

Tested on the phone, working fine.

Thanks Salva!

Comment 13

[Salvador de la Puente González [:salva]]

Master: 77db0e56e2f14fcd007321392b20150581f6c5ae

Comment 14

[Gareth Aye [:gaye] (back from PTO)]

Uplifted 77db0e56e2f14fcd007321392b20150581f6c5ae to:
v1-train: 11df918f3c852e6acf8012ba80f363a64d854e41

Comment 16

[Teodosia Pop]

Verified fixed.

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/39607fd11f6b
Gaia   5d7a0da528dce626b563abafc135eb828599d3c0
BuildID 20130703230208
Version 18.0

Comment 17

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 11df918f3c852e6acf8012ba80f363a64d854e41