Closed Bug 888235 Opened 7 years ago Closed 7 years ago

Use CSSIntSize for nsGlobalWindow::GetInnerWidth/Height

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
No description provided.
Attachment #768896 - Flags: review?(bugmail.mozilla)
Attached patch Patch v1.1Splinter Review
Now with build fixes
Attachment #768896 - Attachment is obsolete: true
Attachment #768896 - Flags: review?(bugmail.mozilla)
Attachment #768902 - Flags: review?(bugmail.mozilla)
Comment on attachment 768902 [details] [diff] [review]
Patch v1.1

Review of attachment 768902 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me but I don't think I'm qualified to review changes to nsGlobalWindow. I don't understand the FORWARD_TO_OUTER business well enough.
Attachment #768902 - Flags: review?(bugmail.mozilla) → feedback+
Attachment #768902 - Flags: review?(mrbkap)
Comment on attachment 768902 [details] [diff] [review]
Patch v1.1

Review of attachment 768902 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindow.cpp
@@ +10838,5 @@
>  
>  void
>  nsGlobalWindow::EnsureSizeUpToDate()
>  {
> +  MOZ_ASSERT(IsOuterWindow());

Nit: add a blank line under this assertion.
Attachment #768902 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/651cebbe91c9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.