888248 - java.lang.NullPointerException: at org.mozilla.gecko.health.BrowserHealthRecorder$<n>.run(BrowserHealthRecorder.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

There are 3 reports including bp-24b42641-0186-428b-bd23-588a12130628.

java.lang.NullPointerException
	at org.mozilla.gecko.health.BrowserHealthRecorder$4.run(BrowserHealthRecorder.java:785)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:32)

More reports at:
https://crash-stats.mozilla.com/query/?product=FennecAndroid&query_search=signature&query_type=contains&query=org.mozilla.gecko.health.BrowserHealthRecorder&reason=&do_query=1

Comment 1

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

Untested.

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 769452 [details] [diff] [review]
Proposed patch. v1

Review of attachment 769452 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/health/BrowserHealthRecorder.java
@@ +783,5 @@
>              @Override
>              public void run() {
> +                final HealthReportDatabaseStorage storage = self.storage;
> +                if (storage == null) {
> +                    Log.d(LOG_TAG, "No storage: shutting down?");

Can you say something less generic, like "No storage: not recording search. Shutting down?"

Comment 3

[Richard Newman [:rnewman]]

https://hg.mozilla.org/services/services-central/rev/d8d375e82d13

Comment 4

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/mozilla-central/rev/d8d375e82d13

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 769452 [details] [diff] [review]
Proposed patch. v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Initial FHR landing.

User impact if declined: 
  Some number of crashes.

Testing completed (on m-c, etc.): 
  Landed on m-c; can't really verify until we see whether crash rate goes down.

Risk to taking this patch (and alternatives if risky): 
  Should be none: just null checks.

String or IDL/UUID changes made by this patch:
  None.

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 769452 [details] [diff] [review]
Proposed patch. v1

Early enough in the cycle to take a fix for a non-topcrash null check.

Comment 7

[Richard Newman [:rnewman]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/adaa503105d1
https://hg.mozilla.org/releases/mozilla-beta/rev/6d3f2be5fffd