Closed
Bug 888310
Opened 10 years ago
Closed 10 years ago
Use more Services.jsm in SeaMonkey feed discovery and preview.
Categories
(SeaMonkey :: Feed Discovery and Preview, defect)
SeaMonkey
Feed Discovery and Preview
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.22
People
(Reporter: philip.chee, Assigned: philip.chee)
Details
Attachments
(1 file)
21.68 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
Follow up to Bug 735333 (Use Services.prefs in SeaMonkey code: Feeds)
![]() |
Assignee | |
Comment 1•10 years ago
|
||
> +++ b/suite/browser/test/mochitest/test_bug364677.html > +++ b/suite/browser/test/mochitest/test_bug395533.html Minor fix-ups for tests that I ran to verify that my patch doesn't break anything. > +++ b/suite/browser/test/mochitest/test_feed_discovery.html ... > addLoadEvent(function() { > - // Need privs because the feed seems to have an about:feeds principal or some > - // such. It's not same-origin with us in any case. > - netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect"); > - is($("testFrame").contentDocument.documentElement.id, "feedHandler", > + is(SpecialPowers.wrap($("testFrame")).contentDocument.documentElement.id, "feedHandler", > "Feed served as text/xml without a channel/link should have been sniffed"); This test was broken so I ported over the relevant changes from: Bug 829872 : Fix up tests that depend on contentDocument being non-null TEST_PATH=suite/browser/test/test_maxSniffing.html pymake -C ../objdir-sm/ mochitest-chrome 6 INFO Passed: 2 7 INFO Failed: 0 8 INFO Todo: 0 TEST_PATH=suite/browser/test/test_feed_discovery.html pymake -C ../objdir-sm/ mochitest-plain Passed: 27 Failed: 0 Todo: 0 TEST_PATH=suite/browser/test/test_bug364677.html pymake -C ../objdir-sm/ mochitest-plain Passed: 1 Failed: 0 Todo: 0 TEST_PATH=suite/browser/test/test_bug395533.html pymake -C ../objdir-sm/ mochitest-plain Passed: 1 Failed: 0 Todo: 0 TEST_PATH=suite/browser/test/test_registerHandler.html pymake -C ../objdir-sm/ mochitest-plain Passed: 24 Failed: 0 Todo: 1
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #768980 -
Flags: review?(iann_bugzilla)
Comment on attachment 768980 [details] [diff] [review] Patch v1.0 Proposed fix. [check-in comment 3] r=me does not appear to break anything (and even fixes stuff too!)
Attachment #768980 -
Flags: review?(iann_bugzilla) → review+
![]() |
Assignee | |
Comment 3•10 years ago
|
||
Pushed to comm-central a=Callek for CLOSED TREE http://hg.mozilla.org/comm-central/rev/b1317c3ff66d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.22
![]() |
Assignee | |
Updated•10 years ago
|
Attachment #768980 -
Attachment description: Patch v1.0 Proposed fix. → Patch v1.0 Proposed fix. [check-in comment 3]
You need to log in
before you can comment on or make changes to this bug.
Description
•