888329 - Defect - Mouse scrollbars remain visible on the first browser we open

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P2)

Description

[Jim Mathies [:jimm]]

STR:

1) open a scrollable page
2) move the mouse to bring up mouse scrollbars
3) touch down on the page and scroll

result: both touch scroll indicator and mouse scrollbar is visible

1) open a scrollable page
2) move the mouse to bring up mouse scrollbars
3) tap the page once
4) touch down on the page and scroll

result: mouse scrollbars will hide on step #3, and will not be visible in step #4. (correct behavior)

Comment 1

[Jim Mathies [:jimm]]

sorry, wrong tracker.

Comment 2

[Jim Mathies [:jimm]]

Attachment: fix

This does a few things - 

- adds a touchstart listener in InputSourceHelper so we transition sooner
- makes sure we fire the initial event on startup via the undefined checks on isPrecise.
- gets rid of a bunch of treatMouseAsTouch gunk we've dropped

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 769429 [details] [diff] [review]
fix

This still isn't fixed completely even with this patch. I think there's something deeper here related to xul scrollbar visibility. The overflow css doesn't seem to work in all cases.

Comment 4

[Jim Mathies [:jimm]]

Interesting bug, for some reason the very first tab browser we create ignores our overflow css, and also ignores changes to the input broadcast property. New tabs don't have this problems. Not sure what causes this, the first tab loads early and is obscured by the start page. That might have something to do with it.

Comment 5

[Jim Mathies [:jimm]]

Attachment: fix v.2

The trick here seems to be init normally with scrollbars, and fire off the imprecise type once the browser loads. It's an odd fix but works.

Comment 6

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 769917 [details] [diff] [review]
fix v.2

Review of attachment 769917 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, works for me.

Comment 7

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c94fdeb1fa66

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for causing the failures in bug 889694: http://hg.mozilla.org/integration/mozilla-inbound/rev/2dbcdd077b2c

Comment 9

[Jim Mathies [:jimm]]

(In reply to Wes Kocher (:KWierso) from comment #8)
> Backed out for causing the failures in bug 889694:
> http://hg.mozilla.org/integration/mozilla-inbound/rev/2dbcdd077b2c

Pushed a fix to try. The selection tests assumed imprecise on startup, I've added some code to their startup functions that sets imprecise on the input helper and fires an update. Fixed this issue locally for me.

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/382cfd96a8a8

Comment 11

[juan becerra [:juanb]]

Tested on 2013-07-17 using latest nightly built from http://hg.mozilla.org/mozilla-central/rev/0888e29c83a3

Tested with first and second part of steps to reproduce in comment #0. I can still see the problem described in the first part. If you load this bug in Firefox Metro and you touch down on the mousepad to display the cursor and then touch and scroll you will see both the touch scroll indicator and mouse scrollbar. I tried this on a laptop and a tablet.

The second part I can no longer reproduce.

Comment 12

[Jim Mathies [:jimm]]

Confirming this is still happening, although it's caused by a different problem. Something is sending the front end a delayed mousemove after touchstart which flips us back to precise mode. I can one-off this by flipping back on touchmoves, but first I'd like to find out where that late mousemove event is coming from. That seems like it might be a bug somewhere in our front end, widget, or event state.

Comment 13

[Jim Mathies [:jimm]]

Since this is a new bug, I've filed 896017. Closing as the original problem with the first tab is in fact fixed.

Comment 14

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130806104538
Built from http://hg.mozilla.org/mozilla-central/rev/1e381c91885d

WFM
Tested on windows 8 using latest nightly. 
STR
1) open a scrollable page
2) move the mouse to bring up mouse scrollbars
3) tap the page once
4) touch down on the page and scroll

result: mouse scrollbars were hidden on step #3, and step #4.

Comment 15

[Samvedana (:Samvedana)]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130815030203
Built from http://hg.mozilla.org/mozilla-central/rev/a8daa428ccbc

WFM
Tested on windows 8 using latest nightly for iteration-12. 

STR
1) open a scrollable page
2) move the mouse to bring up mouse scrollbars
3) tap the page once
4) touch down on the page and scroll

result: mouse scrollbars were hidden on step #3, and step #4.