888356 - [bugsy] /bugs/ layout regressions by sandstone

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect)

Description

[Axel Hecht [:Pike]]

https://l10n.mozilla.org/bugs/ looks funky with sandstone, it's tucked to the left.

Not sure why just that page.

https://l10n.mozilla.org/bugs/new-locale has an unfortunate combination of <code> and not, I guess.

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Axel Hecht [:Pike] from comment #0)
> https://l10n.mozilla.org/bugs/ looks funky with sandstone, it's tucked to
> the left.

Checked out of curiosity, trying to learn new things :-)

https://github.com/mozilla/elmo/blob/master/apps/bugsy/templates/bugsy/index.html#L25

Looks like it's closing a <div> instead of <p>, my 0.02€ are on that.

> 
> https://l10n.mozilla.org/bugs/new-locale has an unfortunate combination of
> <code> and not, I guess.

Comment 2

[Axel Hecht [:Pike]]

Attachment: fix markup, and move <code> element out of <h3>

flod was right, wrong closing tag.

For the new-locale page, I just went the simple way out and moved the <code> piece out of the <h3> tag.

Matjaz, up for a review?

Comment 3

[Matjaz Horvat [:mathjazz]]

Comment on attachment 769106 [details] [diff] [review]
fix markup, and move <code> element out of <h3>

Review of attachment 769106 [details] [diff] [review]:
-----------------------------------------------------------------

The markup fix looks ok.

Moving <code> element out of <h3> also works for me, but I don't understand why we need it.

Comment 4

[Axel Hecht [:Pike]]

The problem with <code> inside <h3> is that code comes with an explicit fontsize in sandstone, https://github.com/mozilla/elmo/blob/master/lib/sandstone/static/css/sandstone/sandstone-resp.less#L225

Thinking about it, I think I prefer 

h3 code {
    font-size: inherit;
}

to be added to the page's CSS.

Comment 5

[Matjaz Horvat [:mathjazz]]

Yup, font-size: inherit looks better.

Comment 6

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/e7a4cb1c43ce5a15a80c338c30e63ebef596c62d
bug 888356, fix sandstone regressions for the bugsy app, r=mathjazz

Comment 7

[Axel Hecht [:Pike]]

I've taken the liberty to do a few more things:

I removed the inline style in new-locale.html that wasn't used anywhere, and I fixed the duplicated file-bugs.css/file_bugs.css, keeping the file-bugs.css only.