888423 - [socorro-crashstats] [traceback] UndefinedError: parameter 'current_page' was not provided

Status: VERIFIED FIXED

(Socorro Graveyard :: Middleware, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

http://crash-stats-new-dev.allizom.org/query/?product=Firefox&version=ALL%3AALL&range_value=1&range_unit=weeks&date=06%2F28%2F2013+18%3A00%3A00&query_search=signature&query_type=contains&query=&reason=&release_channels=&build_id=&process_type=any&hang_type=any throws:

UndefinedError: parameter 'current_page' was not provided

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "crashstats/crashstats/decorators.py", line 48, in inner
    return view(request, *args, **kwargs)
  File "crashstats/crashstats/views.py", line 1437, in query
    return render(request, 'crashstats/query.html', context)
  File "django/shortcuts/__init__.py", line 44, in render
    return HttpResponse(loader.render_to_string(*args, **kwargs),
  File "django/template/loader.py", line 176, in render_to_string
    return t.render(context_instance)
  File "jingo/__init__.py", line 189, in render
    return super(Template, self).render(context_dict)
  File "jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)
  File "/data/socorro-crashstats/crashstats/crashstats/templates/crashstats/query.html", line 1, in top-level template code
    {% extends "crashstats_base.html" %}
  File "/data/socorro-crashstats/crashstats/base/templates/crashstats_base.html", line 106, in top-level template code
    {% block content %}{% endblock %}
  File "/data/socorro-crashstats/crashstats/crashstats/templates/crashstats/query.html", line 208, in block "content"
    {{ pagination(query), current_url, current_page }}
  File "/data/socorro-crashstats/crashstats/base/templates/macros/pagination.html", line 6, in template
    {% if current_page > 1 %}

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

I can't reproduce it locally, I suspect this is a caching problem. Is it possible that the templates were not updated after the build?

Comment 2

[Peter Bengtsson [:peterbe]]

Pull request: https://github.com/mozilla/socorro-crashstats/pull/405

Comment 4

[Peter Bengtsson [:peterbe]]

Replaced by https://github.com/mozilla/socorro-crashstats/issues/406

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/dd799c32bac96aca3cf3408e2f4ef8969838fd83
Fixes bug 888423 - Fixed typo in search page, added pagination unit test.

https://github.com/mozilla/socorro-crashstats/commit/c99673d64cd6b23c36cdfe4a4f54c31e26415f8c
Merge pull request #406 from AdrianGaudebert/888423-fix-pagination-on-search

Fixes bug 888423 - Fixed typo in search page, added pagination unit test.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED, thanks!

https://crash-stats-dev.allizom.org/query/?product=Firefox&version=ALL%3AALL&platform=win&platform=win&platform=mac&platform=lin&range_value=8&range_unit=weeks&date=07%2F03%2F2013+17%3A00%3A00&query_search=signature&query_type=contains&query=&reason=&release_channels=&build_id=&process_type=any&hang_type=any