Closed Bug 888432 Opened 12 years ago Closed 8 years ago

devicemanager's reboot method is inconsistent between subclasses and sometimes confusing

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: wlach, Assigned: gbrown)

Details

devicemanagerADB's reboot command has a single optional parameter called "wait" (off by default), which indicates that the call should block until the device has truly rebooted. devicemanagerSUT takes optional ipAddr and port parameters, and sets up a listening server on said port and blocks until a message is received there if they are set (doing nothing if they are not set) There's really no good reason I can see we should need to manually specify the ip address and port for callbacks in the SUT case (although we may want to keep them for backwards compatibility with releng's sut_tools). Also, I think we should wait by default. See also bug 793362.
Assignee: nobody → gbrown
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.