Add node deletion/insertion to the remote protocol

RESOLVED FIXED in Firefox 25

Status

defect
RESOLVED FIXED
6 years ago
Last year

People

(Reporter: dcamp, Assigned: dcamp)

Tracking

unspecified
Firefox 25
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch v1Splinter Review
No description provided.
Attachment #769255 - Flags: review?(jwalker)
Comment on attachment 769255 [details] [diff] [review]
v1

Review of attachment 769255 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/inspector.js
@@ +1382,5 @@
>    }),
>  
>    /**
> +   * Removes a node from its parent node.
> +   *   

I'm not sure if we care about trailing space here, but there is some.

::: toolkit/devtools/server/tests/mochitest/inspector-helpers.js
@@ +154,5 @@
>    let serverTree = serverOwnershipTree(walker);
>    let clientTree = clientOwnershipTree(walker);
>    is(JSON.stringify(clientTree, null, ' '), JSON.stringify(serverTree, null, ' '), "Server and client ownership trees should match.");
>  
> +  dump("ownership tree: " + JSON.stringify(clientTree, null, ' ') + "\n");

Remove dump?
Attachment #769255 - Flags: review?(jwalker) → review+
All this needs I think is a s/Promise/promise/g.
https://hg.mozilla.org/integration/fx-team/rev/829c270f0005
Assignee: nobody → dcamp
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/829c270f0005
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.