888528 - Add node deletion/insertion to the remote protocol

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Dave Camp (:dcamp)]

Attachment: v1

Comment 1

[Joe Walker [:jwalker]]

Comment on attachment 769255 [details] [diff] [review]
v1

Review of attachment 769255 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/inspector.js
@@ +1382,5 @@
>    }),
>  
>    /**
> +   * Removes a node from its parent node.
> +   *   

I'm not sure if we care about trailing space here, but there is some.

::: toolkit/devtools/server/tests/mochitest/inspector-helpers.js
@@ +154,5 @@
>    let serverTree = serverOwnershipTree(walker);
>    let clientTree = clientOwnershipTree(walker);
>    is(JSON.stringify(clientTree, null, ' '), JSON.stringify(serverTree, null, ' '), "Server and client ownership trees should match.");
>  
> +  dump("ownership tree: " + JSON.stringify(clientTree, null, ' ') + "\n");

Remove dump?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Backed out for mochitest-other orange.
https://hg.mozilla.org/integration/fx-team/rev/042542ff6ec1

https://tbpl.mozilla.org/php/getParsedLog.php?id=25182289&tree=Fx-Team

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

All this needs I think is a s/Promise/promise/g.

Comment 4

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/829c270f0005

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/829c270f0005