888552 - Use SET ps command to configure power save mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Michael Wu [:mwu]]

"SET ps N" is the standard command to enable/disable power save.

Comment 1

[Michael Wu [:mwu]]

Attachment: Use the standard command to enable PS mode

Comment 2

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 769290 [details] [diff] [review]
Use the standard command to enable PS mode

Review of attachment 769290 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wifi/WifiWorker.js
@@ +502,1 @@
>    }

Seems like the command is different between ICS and Jellybean version. 
Maybe we should have a flag here.  

Reference link: 
http://androidxref.com/4.0.4/xref/frameworks/base/core/jni/android_net_wifi_Wifi.cpp#421
http://androidxref.com/4.2.2_r1/xref/frameworks/base/wifi/java/android/net/wifi/WifiNative.java#490

Comment 3

[Michael Wu [:mwu]]

I think PS set is actually supported on many ICS devices. However, I don't care enough to verify that it's supported on all devices, so let's make it JB only.

Comment 4

[Michael Wu [:mwu]]

Attachment: Use the standard command to enable PS mode, v2

Comment 5

[Michael Wu [:mwu]]

https://hg.mozilla.org/projects/birch/rev/be2dca5279ab

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/be2dca5279ab