888563 - Update identity-icons-brand(@2x).png for unofficial, Nightly, and Aurora

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Bug 750106 introduces a chrome site identity design, but we need the icons for the unofficial, Nightly, and Aurora. Both Nightly and Aurora are showing the Firefox icons for now, and unofficial is showing the generic globe icons.

Comment 1

[u428464]

It would be nice to have the text color match the different branding colors.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Guillaume C. [:ge3k0s] from comment #1)
> It would be nice to have the text color match the different branding colors.

It should already be matching the branding colors. What color values do you think they should be changed to? See http://hg.mozilla.org/mozilla-central/file/e24391ffbe7e/browser/themes/shared/identity-block.inc.css#l23 for the color values used for each release channel.

Comment 3

[u428464]

Yeap. I had troubled noticing it with the "UX" but I see it now on Nightly.

Comment 4

[Stephen Horlander [:shorlander]]

Attachment: Aurora - i01

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: Aurora - i01 @2x

Comment 6

[Stephen Horlander [:shorlander]]

Attachment: Nightly - i01

Comment 7

[Stephen Horlander [:shorlander]]

Attachment: Nightly - i01 @2x

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Taking it from here, I don't know how I missed this! :)

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Also updated the colors for Aurora and Nightly to use the correct colors as specified on http://www.mozilla.org/en-US/styleguide/identity/firefox/color/

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v1.1

Forgot to update the unofficial branding.

Comment 11

[Matthew N. [:MattN]]

Comment on attachment 774452 [details] [diff] [review]
Patch v1.1

Review of attachment 774452 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/identity-block.inc.css
@@ +32,5 @@
>                                      rgba(229,114,0,.5) 65%,
>                                      rgba(229,114,0,0));
>  %else
>  %if MOZ_UPDATE_CHANNEL == aurora
> +  color: hsl(212,100%,28%);

Any reason not to also convert these to rgb to match the official branding rules above and the style guide? I had to check the conversions because they style guide doesn't have hsl.

@@ +33,5 @@
>                                      rgba(229,114,0,0));
>  %else
>  %if MOZ_UPDATE_CHANNEL == aurora
> +  color: hsl(212,100%,28%);
> +  background-image: linear-gradient(hsla(212,100%,28%,0),

Looks like you accidentally used the Nightly colours for Aurora as well.

@@ +41,2 @@
>  %else
> +  color: hsl(212,100%,28%);

I don't see how you got this colour from the style guide? Did you adjust it in some way?

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v1.2

Um... I guess I need to sleep more? Sorry for the failed patch (I had interpreted the values on the color page as HSL but they are HSB). This one should be better.

Comment 13

[Matthew N. [:MattN]]

Comment on attachment 774713 [details] [diff] [review]
Patch v1.2

No problem. It was late when I was reviewing that and I wondered if I totally missed something :P

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b65f5117b3eb

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b65f5117b3eb