Closed Bug 888563 Opened 7 years ago Closed 7 years ago

Update identity-icons-brand(@2x).png for unofficial, Nightly, and Aurora

Categories

(Firefox :: Address Bar, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 25

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(5 files, 2 obsolete files)

Bug 750106 introduces a chrome site identity design, but we need the icons for the unofficial, Nightly, and Aurora. Both Nightly and Aurora are showing the Firefox icons for now, and unofficial is showing the generic globe icons.
It would be nice to have the text color match the different branding colors.
(In reply to Guillaume C. [:ge3k0s] from comment #1)
> It would be nice to have the text color match the different branding colors.

It should already be matching the branding colors. What color values do you think they should be changed to? See http://hg.mozilla.org/mozilla-central/file/e24391ffbe7e/browser/themes/shared/identity-block.inc.css#l23 for the color values used for each release channel.
Yeap. I had troubled noticing it with the "UX" but I see it now on Nightly.
Assignee: nobody → shorlander
Status: NEW → ASSIGNED
Taking it from here, I don't know how I missed this! :)
Assignee: shorlander → jaws
Attached patch Patch (obsolete) — Splinter Review
Also updated the colors for Aurora and Nightly to use the correct colors as specified on http://www.mozilla.org/en-US/styleguide/identity/firefox/color/
Attachment #774451 - Flags: review?(mnoorenberghe+bmo)
Attachment #774451 - Attachment is obsolete: true
Attachment #774451 - Flags: review?(mnoorenberghe+bmo)
Attached patch Patch v1.1 (obsolete) — Splinter Review
Forgot to update the unofficial branding.
Attachment #774452 - Flags: review?(mnoorenberghe+bmo)
Comment on attachment 774452 [details] [diff] [review]
Patch v1.1

Review of attachment 774452 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/identity-block.inc.css
@@ +32,5 @@
>                                      rgba(229,114,0,.5) 65%,
>                                      rgba(229,114,0,0));
>  %else
>  %if MOZ_UPDATE_CHANNEL == aurora
> +  color: hsl(212,100%,28%);

Any reason not to also convert these to rgb to match the official branding rules above and the style guide? I had to check the conversions because they style guide doesn't have hsl.

@@ +33,5 @@
>                                      rgba(229,114,0,0));
>  %else
>  %if MOZ_UPDATE_CHANNEL == aurora
> +  color: hsl(212,100%,28%);
> +  background-image: linear-gradient(hsla(212,100%,28%,0),

Looks like you accidentally used the Nightly colours for Aurora as well.

@@ +41,2 @@
>  %else
> +  color: hsl(212,100%,28%);

I don't see how you got this colour from the style guide? Did you adjust it in some way?
Attachment #774452 - Flags: review?(mnoorenberghe+bmo) → review-
Attached patch Patch v1.2Splinter Review
Um... I guess I need to sleep more? Sorry for the failed patch (I had interpreted the values on the color page as HSL but they are HSB). This one should be better.
Attachment #774452 - Attachment is obsolete: true
Attachment #774713 - Flags: review?(mnoorenberghe+bmo)
Comment on attachment 774713 [details] [diff] [review]
Patch v1.2

No problem. It was late when I was reviewing that and I wondered if I totally missed something :P
Attachment #774713 - Flags: review?(mnoorenberghe+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/b65f5117b3eb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.