888584 - Lazily load IdentityUtils.jsm

Status: RESOLVED FIXED

(Core Graveyard :: Identity, defect)

Description

[Matthew N. [:MattN]]

Attachment: v.1 Use XPCOMUtils.defineLazyModuleGetter

It seems like IdentityUtils.jsm doesn't need to be loaded at startup so we can lazily load it for reduce memory usage.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=91d678e90cec

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Nice.  Thanks, Matthew.

Comment 2

[Nicholas Nethercote [inactive]]

From my current four hour old session:

│  │   │  ├──────37,592 B (00.01%) -- compartment([System Principal], resource://gre/modules/identity/IdentityUtils.jsm)
│  │   │  │      ├──23,680 B (00.00%) -- gc-heap
│  │   │  │      │  ├──14,912 B (00.00%) ── sundries
│  │   │  │      │  └───8,768 B (00.00%) ── objects/function
│  │   │  │      └──13,912 B (00.00%) ── other-sundries

I think this is small enough to WONTFIX.

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 769344 [details] [diff] [review]
v.1 Use XPCOMUtils.defineLazyModuleGetter

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/f713336da7ef
Try push: https://tbpl.mozilla.org/?tree=Try&rev=7ddc5697c126

(In reply to Nicholas Nethercote [:njn] from comment #2)
> I think this is small enough to WONTFIX.

There is also time spent loading the JSM that is saved by making this lazy.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f713336da7ef