Closed
Bug 888584
Opened 11 years ago
Closed 11 years ago
Lazily load IdentityUtils.jsm
Categories
(Core Graveyard :: Identity, defect)
Core Graveyard
Identity
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla25
People
(Reporter: MattN, Assigned: MattN)
References
()
Details
(Whiteboard: [MemShrink:P3])
Attachments
(1 file)
5.45 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
It seems like IdentityUtils.jsm doesn't need to be loaded at startup so we can lazily load it for reduce memory usage. Try push: https://tbpl.mozilla.org/?tree=Try&rev=91d678e90cec
Attachment #769344 -
Flags: review?(khuey)
Attachment #769344 -
Flags: review?(jparsons)
Attachment #769344 -
Flags: review?(khuey) → review+
Comment 1•11 years ago
|
||
Nice. Thanks, Matthew.
Comment 2•11 years ago
|
||
From my current four hour old session: │ │ │ ├──────37,592 B (00.01%) -- compartment([System Principal], resource://gre/modules/identity/IdentityUtils.jsm) │ │ │ │ ├──23,680 B (00.00%) -- gc-heap │ │ │ │ │ ├──14,912 B (00.00%) ── sundries │ │ │ │ │ └───8,768 B (00.00%) ── objects/function │ │ │ │ └──13,912 B (00.00%) ── other-sundries I think this is small enough to WONTFIX.
Whiteboard: [MemShrink] → [MemShrink:P3]
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 769344 [details] [diff] [review] v.1 Use XPCOMUtils.defineLazyModuleGetter Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/f713336da7ef Try push: https://tbpl.mozilla.org/?tree=Try&rev=7ddc5697c126 (In reply to Nicholas Nethercote [:njn] from comment #2) > I think this is small enough to WONTFIX. There is also time spent loading the JSM that is saved by making this lazy.
Attachment #769344 -
Flags: review?(jparsons)
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f713336da7ef
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•