Closed
Bug 888622
Opened 12 years ago
Closed 12 years ago
Compositor incorrectly assumes root layer is of type ContainerLayer
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: BenWa, Unassigned)
References
Details
Attachments
(1 file)
|
6.14 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
The root layer is of type Layer and can be a type such as a ColorLayer:
http://hg.mozilla.org/mozilla-central/file/ba1617e2e67d/layout/base/nsPresShell.cpp#l5606
But in the IPC/Compositor code we cast it to a container layer:
http://hg.mozilla.org/mozilla-central/file/ba1617e2e67d/gfx/layers/ipc/LayerTransactionParent.cpp#l346
|
Reporter | |
Comment 1•12 years ago
|
||
Assuming there's no bad cast this patch should be it (for omtc mac at least):
https://tbpl.mozilla.org/?tree=Try&rev=e826ef1b22fb
|
|
Reporter | |
Updated•12 years ago
|
Attachment #770012 -
Attachment is patch: true
|
|
Reporter | |
Updated•12 years ago
|
Attachment #770012 -
Flags: review?(bugmail.mozilla)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 770012 [details] [diff] [review]
patch
Review of attachment 770012 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #770012 -
Flags: review?(bugmail.mozilla) → review+
|
|
Reporter | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•