888665 - Bad stored add-ons cause document generation failure in the presence of good add-ons

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Android, defect, P1)

Description

[Richard Newman [:rnewman]]

Follow-on from Bug 886156. For clients that ended up with null add-ons, and now have a valid collection, document generation will fail:

 Generating report failed; responding with null.
 java.lang.NullPointerException
 	at org.mozilla.gecko.background.healthreport.HealthReportGenerator.diff(HealthReportGenerator.java:454)
 	at org.mozilla.gecko.background.healthreport.HealthReportGenerator.getActiveAddons(HealthReportGenerator.java:527)
 	at org.mozilla.gecko.background.healthreport.HealthReportGenerator.jsonify(HealthReportGenerator.java:284)
 	at org.mozilla.gecko.background.healthreport.HealthReportGenerator.getEnvironmentsJSON(HealthReportGenerator.java:260)
 	at org.mozilla.gecko.background.healthreport.HealthReportGenerator.generateDocument(HealthReportGenerator.java:85)
 	at org.mozilla.gecko.background.healthreport.HealthReportGenerator.generateDocument(HealthReportGenerator.java:48)
 	at org.mozilla.gecko.health.BrowserHealthReporter.generateReport(BrowserHealthReporter.java:94)
 	at org.mozilla.gecko.health.BrowserHealthReporter.generateReport(BrowserHealthReporter.java:112)
 	at org.mozilla.gecko.health.BrowserHealthReporter$1.run(BrowserHealthReporter.java:123)
 	at android.os.Handler.handleCallback(Handler.java:615)
 	at android.os.Handler.dispatchMessage(Handler.java:92)
 	at android.os.Looper.loop(Looper.java:155)
 	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:32)

I would like to fix this before uplifting Bug 886156; the current behavior is "broken but working".

Comment 1

[Richard Newman [:rnewman]]

https://github.com/mozilla-services/android-sync/pull/323

Comment 2

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1 (from git)

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 769453 [details] [diff] [review]
Proposed patch. v1 (from git)

Review of attachment 769453 [details] [diff] [review]:
-----------------------------------------------------------------

reviewed on github.

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/services/services-central/rev/a0a3099e79d5

Comment 5

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/mozilla-central/rev/a0a3099e79d5

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 769453 [details] [diff] [review]
Proposed patch. v1 (from git)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Initial FHR landing.

User impact if declined: 
  Users who were affected by Bug 886156 will be unable to generate or submit documents unless this change lands, because defective data made it into the DB.

Testing completed (on m-c, etc.): 
  Verified on personal device (which was affected!), landed on m-c.

Risk to taking this patch (and alternatives if risky): 
  Should be ~none; null checks.

String or IDL/UUID changes made by this patch:
  None.

Comment 7

[bhavana bajaj [:bajaj]]

Comment on attachment 769453 [details] [diff] [review]
Proposed patch. v1 (from git)

low risk, null check...Adding verifyme once this lands on beta.

Comment 8

[Richard Newman [:rnewman]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d79d7d818dc6
https://hg.mozilla.org/releases/mozilla-beta/rev/7b930395d8d9