888801 - Contacts API: Remove searchable fields from IPC transfer in cached scenario

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

Currently we copy all information to the child when we use cursors. We should use makeExport to strip unneeded info.

Comment 1

[Reuben Morais [:reuben]]

Attachment: Patch

Comment 2

[Gregor Wagner [:gwagner]]

Comment on attachment 769999 [details] [diff] [review]
Patch

Review of attachment 769999 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: dom/contacts/fallback/ContactDB.jsm
@@ +31,5 @@
> +
> +  for (let field in aRecord.properties)
> +    contact.properties[field] = aRecord.properties[field];
> +
> +  contact.properties.secret = !!contact.properties.secret;

Remove this line.

Comment 3

[Reuben Morais [:reuben]]

(In reply to Gregor Wagner [:gwagner] from comment #2)
> Remove this line.

Why? It's there so we send a bool back instead of an integer. We store it as a number because you can't create an index over a boolean property.

Comment 4

[Reuben Morais [:reuben]]

https://hg.mozilla.org/projects/birch/rev/1c2f163cbebc

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1c2f163cbebc