Contacts API: Remove searchable fields from IPC transfer in cached scenario

RESOLVED FIXED in mozilla25

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gwagner, Assigned: reuben)

Tracking

(Blocks: 1 bug)

unspecified
mozilla25
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-birch])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Currently we copy all information to the child when we use cursors. We should use makeExport to strip unneeded info.
(Assignee)

Comment 1

5 years ago
Created attachment 769999 [details] [diff] [review]
Patch
Attachment #769999 - Flags: review?(anygregor)
(Reporter)

Comment 2

5 years ago
Comment on attachment 769999 [details] [diff] [review]
Patch

Review of attachment 769999 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: dom/contacts/fallback/ContactDB.jsm
@@ +31,5 @@
> +
> +  for (let field in aRecord.properties)
> +    contact.properties[field] = aRecord.properties[field];
> +
> +  contact.properties.secret = !!contact.properties.secret;

Remove this line.
Attachment #769999 - Flags: review?(anygregor) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Gregor Wagner [:gwagner] from comment #2)
> Remove this line.

Why? It's there so we send a bool back instead of an integer. We store it as a number because you can't create an index over a boolean property.
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/projects/birch/rev/1c2f163cbebc
Whiteboard: [fixed-in-birch]

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/1c2f163cbebc
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
(Assignee)

Updated

5 years ago
Blocks: 888666
You need to log in before you can comment on or make changes to this bug.