888836 - Firefox Beta stops playing downloaded mp3s when android screen is locked

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Frederik Braun [:freddy]]

This happens only in beta, not in the release version of Firefox.

STR:
1. Click on an MP3 link (the file is opened in the same window, audio controls show up. it starts downloading and starts to play)
1a. Actually, it could be that you have to click play manually...
3. Lock the Android Screen
4. The audio stops

On the release version, the audio keeps playing..

Comment 1

[Wesley Johnston (:wesj)]

I saw this the other day too on NPR.com. Its from bug 809558. I'm going to look into disable audioChannels in non-webapps.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

This turns this off for Fennec and on for apps. That brings us in line with b2g, but if we want, we could also just turn this off on beta/aurora?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 769766 [details] [diff] [review]
Patch

>diff --git a/mobile/android/app/mobile.js b/mobile/android/app/mobile.js

> // Make <audio> and <video> talk to the AudioChannelService.
>-pref("media.useAudioChannelService", true);
>+pref("media.useAudioChannelService", false);

Tweak the comment a bit? Make it more agnostic to the setting?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Yeah, let turn this off on Aurora and Beta

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e01fb914a16

Will post a new patch for beta and aurora.

Comment 6

[Wesley Johnston (:wesj)]

Attachment: Patch for beta/aurora

Comment 7

[Wesley Johnston (:wesj)]

Comment on attachment 769858 [details] [diff] [review]
Patch for beta/aurora

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 809558
User impact if declined: Audio turns off as soon as you switch tabs/apps etc from Fennec.
Testing completed (on m-c, etc.): Landed on mc today
Risk to taking this patch (and alternatives if risky): Very low risk. Pref flip. Pref is not enabled for desktop either.
String or IDL/UUID changes made by this patch: None.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7e01fb914a16

Comment 9

[Wesley Johnston (:wesj)]

beta: https://hg.mozilla.org/releases/mozilla-beta/rev/42640339a50c
aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/442533851168

Comment 10

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 25.0a1(2013-07-03) and Firefox for Android 24.0a2(2013-07-03)
Device: LG Nexus 4
OS: Android 4.2.2

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 26.0b6
Device: LG Nexus 4
OS: Android 4.2.2