Enhance controller.restartApllication() to handle custom restart flags

RESOLVED INVALID

Status

Testing Graveyard
Mozmill
RESOLVED INVALID
5 years ago
2 years ago

People

(Reporter: Andrei Eftimie, Assigned: Andrei Eftimie)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
For bug 886811 we need to send a custom restart type for some tests (mainly OSX restartChangeArchitecture tests) in controller.restartApplication()

The method should be able to receive a new argument with a custom restart type, and default to what it uses now.
(Assignee)

Updated

5 years ago
Summary: Enhance controller.restartApllication() to handle custom restart types → Enhance controller.restartApllication() to handle custom restart falgs
(Assignee)

Comment 1

5 years ago
Created attachment 770147 [details] [diff] [review]
patch v1

I need this for bug 886811 to be able to send custom restart flags for the OSX restartChangeArchitecture tests.

We used to do a startUserShutdown() then do a custom restart.
When we change that to restartApplication() we need to be able to specify those custom restart flags.

I am not sure that this would be the right approach.

A testrun (no new failures) http://mozmill-crowd.blargon7.com/#/functional/report/a1b02004612785c13cf7c6bf1e69e99d
Attachment #770147 - Flags: feedback?(hskupin)
Attachment #770147 - Flags: feedback?(dave.hunt)
Summary: Enhance controller.restartApllication() to handle custom restart falgs → Enhance controller.restartApllication() to handle custom restart flags
Comment on attachment 770147 [details] [diff] [review]
patch v1

Review of attachment 770147 [details] [diff] [review]:
-----------------------------------------------------------------

This approach looks good to me. I'll probably defer to Henrik for the final review though.

::: mozmill/mozmill/extension/resource/driver/controller.js
@@ +429,5 @@
> + *        Bitwise flag on how to do a shutdown. See:
> + *        https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIAppStartup#Constants
> + */
> +MozMillController.prototype.restartApplication = function (aNext, aResetProfile,
> +                                                           aUserRestart,aRestartFlag) {

Nit: Missing whitespace after comma.
Attachment #770147 - Flags: feedback?(hskupin)
Attachment #770147 - Flags: feedback?(dave.hunt)
Attachment #770147 - Flags: feedback+
Comment on attachment 770147 [details] [diff] [review]
patch v1

Review of attachment 770147 [details] [diff] [review]:
-----------------------------------------------------------------

All this is not necessary anymore. I have already added this to my patch on bug 865690 which landed end of last week.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.