888853 - Enhance controller.restartApllication() to handle custom restart flags

Status: RESOLVED INVALID

(Testing Graveyard :: Mozmill, defect)

Description

[Andrei Eftimie]

For bug 886811 we need to send a custom restart type for some tests (mainly OSX restartChangeArchitecture tests) in controller.restartApplication()

The method should be able to receive a new argument with a custom restart type, and default to what it uses now.

Comment 1

[Andrei Eftimie]

Attachment: patch v1

I need this for bug 886811 to be able to send custom restart flags for the OSX restartChangeArchitecture tests.

We used to do a startUserShutdown() then do a custom restart.
When we change that to restartApplication() we need to be able to specify those custom restart flags.

I am not sure that this would be the right approach.

A testrun (no new failures) http://mozmill-crowd.blargon7.com/#/functional/report/a1b02004612785c13cf7c6bf1e69e99d

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 770147 [details] [diff] [review]
patch v1

Review of attachment 770147 [details] [diff] [review]:
-----------------------------------------------------------------

This approach looks good to me. I'll probably defer to Henrik for the final review though.

::: mozmill/mozmill/extension/resource/driver/controller.js
@@ +429,5 @@
> + *        Bitwise flag on how to do a shutdown. See:
> + *        https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIAppStartup#Constants
> + */
> +MozMillController.prototype.restartApplication = function (aNext, aResetProfile,
> +                                                           aUserRestart,aRestartFlag) {

Nit: Missing whitespace after comma.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 770147 [details] [diff] [review]
patch v1

Review of attachment 770147 [details] [diff] [review]:
-----------------------------------------------------------------

All this is not necessary anymore. I have already added this to my patch on bug 865690 which landed end of last week.