Closed Bug 888927 Opened 10 years ago Closed 10 years ago

MOZ_TELEMETRY_ON_BY_DEFAULT should be controlled by the channel-specific build defines, not the update channel

Categories

(Toolkit :: Telemetry, defect)

Product:
Toolkit
Component:
Telemetry
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

Attachments

(1 file)

patch
949 bytes, patch
khuey
: review+
Details | Diff | Splinter Review 
MOZ_TELEMETRY_ON_BY_DEFAULT currently depends on the value of MOZ_UPDATE_CHANNEL, which itself depends on the build configuration and leads to issues like bug 888765.

Instead, it should be controlled by #ifndef release build, which depends on the version of the repository from which the code was built (mozilla-central, mozilla-aurora, mozilla-beta, etc., see https://wiki.mozilla.org/Platform/Channel-specific_build_defines).
Attached patch patch — — Splinter Review 
I suppose this has the downside of enabling telemetry by default on developer-self builds in the cases where you:
- build with MOZ_TELEMETRY_REPORTING
- don't build with --enable-update-channel=nightly|aurora

I think that's unlikely to be a problem in practice.
Attachment #769695 - Flags: review?(khuey)
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/184127374d60
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Depends on: 892990
Blocks: 997820
You need to log in before you can comment on or make changes to this bug.