Closed Bug 888927 Opened 7 years ago Closed 7 years ago
_TELEMETRY _ON _BY _DEFAULT should be controlled by the channel-specific build defines, not the update channel
MOZ_TELEMETRY_ON_BY_DEFAULT currently depends on the value of MOZ_UPDATE_CHANNEL, which itself depends on the build configuration and leads to issues like bug 888765. Instead, it should be controlled by #ifndef release build, which depends on the version of the repository from which the code was built (mozilla-central, mozilla-aurora, mozilla-beta, etc., see https://wiki.mozilla.org/Platform/Channel-specific_build_defines).
I suppose this has the downside of enabling telemetry by default on developer-self builds in the cases where you: - build with MOZ_TELEMETRY_REPORTING - don't build with --enable-update-channel=nightly|aurora I think that's unlikely to be a problem in practice.
Attachment #769695 - Flags: review?(khuey)
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #769695 - Flags: review?(khuey) → review+
Target Milestone: --- → mozilla25
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.