889031 - remove some obsolete code from comm-central

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[:aceman]

There is some code marked obsolete/deprecated with no in-tree users. Let's try to remove it now that TB24 is branched.
Also update some PRInt32 -> int32 types and such stuff.

Comment 1

[:aceman]

Attachment: patch

Comment 2

[[e-mail]]

Comment on attachment 769813 [details] [diff] [review]
patch

>-    return GetAsciiHeader(MSG_TEMPORARY_FILES_HEADER_ID);
>-    }
>+  const char* GetAttachments() {return GetAsciiHeader(MSG_ATTACHMENTS_HEADER_ID);}
This isn't used; neither are either of the enum values, so they can all go. r=me with that fixed based on code inspection.

>-    // make sure the oid of the table is 1.
>-    struct mdbOid folderInfoTableOID;
>-    folderInfoTableOID.mOid_Id = 1;
>-    folderInfoTableOID.mOid_Scope = m_rowScopeToken;
I scoured CVS history, this variable was used for about the first 100 hours of March 1999 before being commented out (and later deleted, but sadly not the declaration).

Comment 3

[:aceman]

Attachment: patch v2

Ok, thanks.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 770447 [details] [diff] [review]
patch v2

Review of attachment 770447 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mkmelin

Comment 5

[:aceman]

Marking addon-compat as some addons may have been using the removed functions. But I intentionally did this after TB24 branched so they have time until TB31 to update.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/9b3d185ac2a9

Comment 7

[Ian Neal]

Comment on attachment 770447 [details] [diff] [review]
patch v2

Neil already gave it an r+ (plus it has landed), so removing the request