Closed
Bug 889053
Opened 12 years ago
Closed 12 years ago
nsCycleCollectorParams::mDoNothing does nothing
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
4.85 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
mParams.mDoNothing is always false, until the very end of Shutdown(). But the only place we call Shutdown() is in nsCycleCollector_shutdown, and we delete the collector right after that, so it doesn't make any sense to have this.
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → continuation
|
|
Assignee | |
Updated•12 years ago
|
Summary: Remove mDoNothing from the cycle collector → nsCycleCollectorParams::mDoNothing does nothing
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 775265 [details] [diff] [review]
mDoNothing does nothing
https://tbpl.mozilla.org/?tree=Try&rev=3e18579173d7
Attachment #775265 -
Flags: review?(khuey)
Attachment #775265 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•