889098 - Images inside toolbar buttons are not displayed anymore

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Sebastian Zartner [:sebo]]

Attachment: Firebug 1.12b1

When an <image> is placed inside a <toolbarbutton> it isn't displayed anymore.
The regression range is around the passed weekend.

Test case:
1. Install the attached Firebug version
2. Press F12 to open Firebug

=> The buttons at the left (#fbFirebugMenu and #fbBreakOnNextButton) are missing their images. See the attached screenshot.

Sebastian

Comment 1

[Sebastian Zartner [:sebo]]

Attachment: Missing icons on toolbar buttons

Comment 2

[:Gijs (he/him)]

Gut feeling: bug 653881. Can you easily check this?

Comment 3

[Sebastian Zartner [:sebo]]

I don't know how to build Firefox myself, so I can't further help you there, but Honza might be able to clarify this.
Though the bug you mention sounds indeed like a probable culprit for this.

Sebastian

Comment 4

[Alice0775 White]

I can confirm the problem


STR
1. Install https://addons.mozilla.org/ja/firefox/addon/firebug/ 1.11.4
2. Restart
3. Click Firebug icon at the end of Nav-bar

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/4df4f2767a69
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130628 Firefox/25.0 ID:20130628184843
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/1b8207252e9c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130628 Firefox/25.0 ID:20130628185242
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4df4f2767a69&tochange=1b8207252e9c

Regressed by : Bug 653881

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

This should be fixed by the patch in bug 888787.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

That patch is now checked in.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Work for me again, thanks!
Honza

Comment 8

[Sebastian Zartner [:sebo]]

Also works for me. So I'm happy again! :-)

Sebastian