Closed
Bug 889099
Opened 12 years ago
Closed 12 years ago
Mark netwerk/sctp/datachannel as FAIL_ON_WARNINGS
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
|
840 bytes,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
With bug 889088 fixed, netwerk/sctp/datachannel is warning-free (on my machine at least) and can probably be marked as FAIL_ON_WARNINGS to keep it that way.
|
Assignee | |
Comment 1•12 years ago
|
||
TBPL run with just this patch (expected to fail):
https://tbpl.mozilla.org/?tree=Try&rev=23f545eda166
TBPL run with this patch layered on top of bug 889088's patch (expected to pass):
https://tbpl.mozilla.org/?tree=Try&rev=e38a42075e86
Attachment #769864 -
Flags: review?(rjesup)
|
|
Assignee | |
Comment 2•12 years ago
|
||
(Looks like there's a windows build warning remaining -- I filed dependent bug 889136 on that.)
|
||
Updated•12 years ago
|
Attachment #769864 -
Flags: review?(rjesup) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Landed this (wiht the fix for the windows build warning, bug 889136, in the same push):
https://hg.mozilla.org/integration/mozilla-inbound/rev/d22d48dff478
Flags: in-testsuite-
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•