Closed
Bug 889104
Opened 11 years ago
Closed 11 years ago
change 'yield;' to 'yield undefined;' where needed
Categories
(MailNews Core :: Backend, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 25.0
People
(Reporter: aceman, Assigned: hiro)
References
Details
Attachments
(1 file)
|
1.63 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
Bug 885463 made the statement 'yield' without argument give a JS warning. We get some of those in comm-central. It also crops up in many xpcshell tests and causes failure of those (at least for me):
TEST-UNEXPECTED-FAIL | ../../../../resources/logHelper.js | Error console says [stackFrame yield without a value is deprecated, and illegal in ES6 (use 'yield undefined' instead)]
You can start with this query:
http://mxr.mozilla.org/comm-central/search?string=yield%3B%24®exp=1&find=%2Fmail&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
|
Assignee | |
Comment 1•11 years ago
|
||
This error annoys me.
|
||
Updated•11 years ago
|
Attachment #770057 -
Flags: review?(mbanner) → review+
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 2•11 years ago
|
||
I pushed this, as I was hitting in xpcshell tests earlier, which was making debugging harder:
https://hg.mozilla.org/comm-central/rev/0db3e5e930fa
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 25.0
You need to log in
before you can comment on or make changes to this bug.
Description
•