889143 - search page should do client-side input validation

Status: RESOLVED WONTFIX

(Socorro :: Webapp, task, P2)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of issue

STR:

1. Load https://crash-stats.mozilla.com/query/?product=Firefox#advanced
2. Type "google.com" into the "Build ID" field
3. Submit the search
4. Get the error message
5. Now, click the Back button

Actual Results:

The AJAX "Processing query, please wait..." message and spinner stay

Comment 1

[Robert Helmer [:rhelmer]]

(In reply to Stephen Donner [:stephend] from comment #0)
> Created attachment 769925 [details]
> Screenshot of issue
> 
> STR:
> 
> 1. Load https://crash-stats.mozilla.com/query/?product=Firefox#advanced
> 2. Type "google.com" into the "Build ID" field
> 3. Submit the search
> 4. Get the error message
> 5. Now, click the Back button
> 
> Actual Results:
> 
> The AJAX "Processing query, please wait..." message and spinner stay

Huh that's weird, not sure what's causing that offhand.. caching maybe?

Comment 2

[Schalk Neethling [:espressive]]

To be honest we should have JS validation here which will completely avoid the problem.

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to Schalk Neethling [:espressive] from comment #2)
> To be honest we should have JS validation here which will completely avoid
> the problem.

Excellent point! Normal users would never need to see the annoying form validation failure error page too which is a bonus.

Comment 4

[Robert Helmer [:rhelmer]]

Morphing bug.

Adrian is this done for the "supersearch" rewrite already? Assuming that's coming soon, we could just do it for the new search app and not bother fixing up the current one.

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

supersearch will remove this problem entirely as results are loading through an AJAX call, and the 'Search' button is never deactivated. 

I'm going to investigate the original problem, as supersearch won't be turned on for all users before another few months I think.

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

So this is indeed a caching problem with the browser. I don't think we want to solve this, it's a trivial problem that would require too much work, especially since supersearch is coming and will solve it. 

Marking as wontfix, reopen if you disagree. :)