889203 - Make Sidebar id optional

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

At the moment a panel id is required, one should be auto generated if it is not provided.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #1)
> At the moment a panel id is required, one should be auto generated if it is
> not provided.

Oops, got panels on the mind.  Make the above:

At the moment a sidebar id is required, one should be auto generated if it is not provided.

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1254

Pointer to Github pull-request

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 811304 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1254

updates made for the review comments.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/24653b6426733813a5c1170da6d112a481646935
Bug 889203 - Make Sidebar id optional

https://github.com/mozilla/addon-sdk/commit/e58881039ec67cdf19bc953a4584c8f729ef71ae
Merge pull request #1254 from erikvold/889203v2

Bug 889203 - Make Sidebar id optional r=@gozala