Status

Add-on SDK
General
P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: erikvold, Assigned: erikvold)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

At the moment a panel id is required, one should be auto generated if it is not provided.
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #1)
> At the moment a panel id is required, one should be auto generated if it is
> not provided.

Oops, got panels on the mind.  Make the above:

At the moment a sidebar id is required, one should be auto generated if it is not provided.
Blocks: 888774
Priority: -- → P2
Depends on: 914475
Depends on: 921202
Assignee: nobody → evold
Created attachment 811304 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1254

Pointer to Github pull-request
Attachment #811304 - Flags: review?(rFobic)
Attachment #811304 - Flags: review?(rFobic) → review-
Comment on attachment 811304 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1254

updates made for the review comments.
Attachment #811304 - Flags: review- → review?(rFobic)
Attachment #811304 - Flags: review?(rFobic) → review+

Comment 4

4 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/24653b6426733813a5c1170da6d112a481646935
Bug 889203 - Make Sidebar id optional

https://github.com/mozilla/addon-sdk/commit/e58881039ec67cdf19bc953a4584c8f729ef71ae
Merge pull request #1254 from erikvold/889203v2

Bug 889203 - Make Sidebar id optional r=@gozala
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.