889211 - [SMS] The delivery report icon for the message is shown with two 'checks'

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Leo]

1. Title: The delivery repory icon for the message is shown with two 'checks'
2. Precondition: Settings -> Cellular & Data -> Message settings -> Enable Delivery reports
3. Tester's Action: 1) Send an sms 
                    2) Check the Delivery Report Icon 
4. Detailed Symptom (ENG.) : The delivery icon contains two 'checks'
5. Expected: One 'check' should be enough because of two checks this is confusing to the user that the message was send to multiple numbers
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train: Reproduced on v1-train
8. Gaia Revision:  613e69ee0a009399130ad2cbb8b9d0462cd1fc70

Comment 1

[Mark Shiao]

Hi Leo,

This is more of an UX issue. Going to ask for UX opinion before moving forward on this.

@Victoria,
Steven Chung said you'd be best to address this UX change request.  Can you provide feedback regarding this change?

Thanks,
Mark

Comment 2

[Victoria Gerchinhoren [:vicky]]

Hi Leo and Mark,
I understand that this can be a bit confusing, so I have changed the icon for only one tick, please use this assets I am attaching.

Comment 3

[Victoria Gerchinhoren [:vicky]]

Attachment: delivery report icon 1x

Comment 4

[Victoria Gerchinhoren [:vicky]]

Attachment: delivery report icon 2x

Comment 5

[Leo]

Hi Victoria,
Thank you for the attachments.
But there are seperate ticks existing in the attachments provided by you.
Can you please check it once.
Thanks

Comment 6

[Victoria Gerchinhoren [:vicky]]

I don't understand your concern, can you explain it better?

I attached 2 files, one for the regular version and one for the HD one. Is that what you're worried about?

Thanks

Comment 7

[Victoria Gerchinhoren [:vicky]]

Or are you reffering to the two icons in different colors? The green is the idle state and the blue one is the pressed state as it is actionable -it triggers an overlay with the status infortmation- so it needs to have a press state.

I hope that answers your question.

Comment 8

[Victoria Gerchinhoren [:vicky]]

Attachment: delivery report icon 1x

Comment 9

[Victoria Gerchinhoren [:vicky]]

Attachment: delivery report icon 2x

Comment 10

[Victoria Gerchinhoren [:vicky]]

PLease download the assets again, I think there was a pixel off in one of them.

THanks!

Comment 11

[Mark Shiao]

Attachment: redirect to pull request

Hi Steve,

Can you please review this one for me?  Just a simple picture replacement from two checks to one check.

Thanks,
Mark

Comment 12

[Steve Chung [:steveck]]

Comment on attachment 771228 [details]
redirect to pull request

Looks fine to me, thanks.

Comment 13

[Mark Shiao]

landed on master

https://github.com/mozilla-b2g/gaia/commit/dad349598e6c1a400f5eb31e032c57db8d9ecf26

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted dad349598e6c1a400f5eb31e032c57db8d9ecf26 to:
v1-train: 7bd0597e6a884dff3fa2650194a599bc454cfc00

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 7bd0597e6a884dff3fa2650194a599bc454cfc00

Comment 16

[bov]

Tested on Unagi device. 
Build:unagi-ICS.user.manifest.V1-train.Rel0.4.Sprint12.B-332.Gecko-f89d83b.Gaia-6221737
Build ID:20130730104759
Commercial RIL: AU 172

1. Settings -> Cellular & Data -> Message settings -> Enable Delivery reports
2. Send a SMS to a contact  
3. Check the Delivery Report Icon in the SMS thread view

Expected result: 
Once the SMS is sent, the thread view shows one green check icon next to the message.

Actual result:
It works well, as expected.

See attachment Test889211.png

Comment 17

[bov]

Attachment: Test889211